Skip to content

EI-301-Close-Modal-Even-If-Fail #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmains515 merged 1 commit into from
Apr 11, 2026
Merged

EI-301-Close-Modal-Even-If-Fail #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions endpoint-insights-ui/src/app/components/create-job-modal/create-job-modal.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,12 @@ describe('CreateJobModal', () => {
component.onSubmit({ jobType: 'E2E', name: 'Test' });
expect(toastServiceSpy.onError).toHaveBeenCalledWith('Failed to create job. Please try again.');
});

it('should close the dialog on failure', () => {
jobServiceSpy.createJob.and.returnValue(throwError(() => new Error('fail')));
component.onSubmit({ jobType: 'E2E', name: 'Test' });
expect(mockDialogRef.close).toHaveBeenCalledTimes(1);
});
});

describe('onCancel', () => {
Expand Down
1 change: 1 addition & 0 deletions endpoint-insights-ui/src/app/components/create-job-modal/create-job-modal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export class CreateJobModal {
error: (error) => {
console.error('Error creating job:', error);
this.toastService.onError('Failed to create job. Please try again.');
this.dialogRef.close();
}
});
}
Expand Down
6 changes: 5 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading