Conversation
PEP 621 optional-dependencies were decoded from TOML but never iterated, so projects like rs-graph that define most deps as optional showed only runtime deps. Now each optional group is parsed and assigned a scope based on the group name (dev/lint -> development, test/testing -> test, everything else -> optional). The setup.py extras_require parser had inverted logic that skipped actual package requirements and kept group names. Replaced with a proper regex that matches each group key and its list of requirements. Fixes git-pkgs/git-pkgs#130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 621
[project.optional-dependencies]was decoded from TOML but never iterated, so projects like rs-graph that define most deps as optional showed only runtime deps. Now each optional group is parsed and assigned a scope based on the group name (dev/lint to development, test/testing to test, everything else to optional).The setup.py
extras_requireparser had inverted logic that skipped actual package requirements and kept group names. Replaced with a proper regex that matches each group key and its list of requirements.Fixes git-pkgs/git-pkgs#130