Conversation
Adds List, Submit, RequestReviewers, and RemoveReviewers to a new
ReviewService interface with implementations for all four platforms.
GitHub and Gitea support the full review model including request-changes.
GitLab and Bitbucket support approve and comment but return ErrNotSupported
for request-changes. GitLab reviewer assignment resolves usernames to IDs.
CLI commands: forge pr review {list,approve,reject} and
forge pr reviewer {request,remove}.
Closes #9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a ReviewService interface with List, Submit, RequestReviewers, and RemoveReviewers methods, implemented across all four platform backends.
GitHub and Gitea support the full review model including request-changes. GitLab and Bitbucket support approve and comment but return ErrNotSupported for request-changes. GitLab reviewer assignment resolves usernames to user IDs automatically.
CLI commands added under
forge pr:forge pr review list <number>forge pr review approve <number>forge pr review reject <number>forge pr reviewer request <number> <users...>forge pr reviewer remove <number> <users...>Closes #9