Skip to content

Conversation

@desmondwong1215
Copy link
Contributor

Exercise Review

Exercise Discussion

#109

Checklist

  • If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
  • Have you written unit tests using repo-smith to validate the exercise grading scheme?
  • Have you tested the download script using test-download.sh?
  • Have you verified that this exercise does not already exist or is not currently in review?
  • Did you introduce a new grading mechanism that should belong to git-autograder?
  • Did you introduce a new dependency that should belong to app?

@damithc
Copy link
Contributor

damithc commented Dec 7, 2025

@desmondwong1215 Just realised you've merged another hands-on practical earlier. OK to go ahead with this one but normally we restrict to one HP per contributor.

@desmondwong1215
Copy link
Contributor Author

Ok noted, prof.

jovnc

This comment was marked as outdated.

Copy link
Contributor

@jovnc jovnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor suggestion to improve code quality and follow conventions of other hands-on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants