-
Notifications
You must be signed in to change notification settings - Fork 26
Implement hands on hp-push-tags #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dingZvel
wants to merge
12
commits into
git-mastery:main
Choose a base branch
from
dingZvel:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7c554f2
Implement hands on hp-push-tags
dingZvel 598a3b8
Fix the cloned repo directory name to REPO_NAME
dingZvel 5dc73ff
Notify user when fork name is changed
dingZvel d851e1d
Abort script when a fork already exists
dingZvel 3aece8a
Merge branch 'git-mastery:main' into main
dingZvel 0b48ebf
Refactor using core util functions for gh
dingZvel d4457fe
Merge branch 'git-mastery:main' into main
dingZvel f003982
Refactor using has_repo util function
dingZvel e1ac310
Fix the name of directory to "gitmastery-samplerepo-preferences"
dingZvel c63cbc2
Merge branch 'git-mastery:main' into main
dingZvel bac4807
Skip and clone when an existing fork is found
dingZvel 246e7c3
Fix based on VikramGoyal23's review
dingZvel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import os | ||
| from exercise_utils.git import tag_with_options, annotated_tag_with_options | ||
| from exercise_utils.github_cli import clone_repo_with_gh, fork_repo, get_fork_name, get_github_username, has_fork, has_repo | ||
|
|
||
| __requires_git__ = True | ||
| __requires_github__ = True | ||
|
|
||
| def check_same_repo_name(username: str, repo_name: str, verbose: bool) -> str: | ||
| if has_repo(repo_name, False, verbose): | ||
| print(f"Warning: {username}/{repo_name} already exists, the fork repo will be " | ||
| f"named as {username}/{repo_name}-1") | ||
| return repo_name + "-1" | ||
| return repo_name | ||
|
|
||
| def download(verbose: bool): | ||
| REPO_NAME = "samplerepo-preferences" | ||
| FORK_NAME = "gitmastery-samplerepo-preferences" | ||
| username = get_github_username(verbose) | ||
|
|
||
| if has_fork(REPO_NAME, "git-mastery", username, verbose): | ||
| existing_name = get_fork_name(REPO_NAME, "git-mastery", username, verbose) | ||
| clone_repo_with_gh(existing_name, verbose, FORK_NAME) | ||
| else: | ||
| NEW_FORK_NAME = check_same_repo_name(username, FORK_NAME, verbose) | ||
| fork_repo(f"git-mastery/{REPO_NAME}", NEW_FORK_NAME, verbose) | ||
| clone_repo_with_gh(NEW_FORK_NAME, verbose, FORK_NAME) | ||
|
|
||
| os.chdir(FORK_NAME) | ||
|
|
||
| tag_with_options("v1.0", ["HEAD~1"], verbose) | ||
| annotated_tag_with_options("v0.9", ["HEAD~2", "-m", "First beta release"], verbose) | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is technically not necessary to have both of these functions, as the
-aflag is unnecessary to make an annotated tag if the-mflag is passed with its message. However, since it increases code readability, I am not opposed to keeping both of these in.