Skip to content

chore(authorship): remove dead LineRange::overlaps and CheckpointKind::from_str #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jwiegley wants to merge 1 commit into
base: dc/authorship-serialization-cleanup
Choose a base branch
from
+0 −31
Open

chore(authorship): remove dead LineRange::overlaps and CheckpointKind::from_str #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions src/authorship/authorship_log.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,20 +24,7 @@ impl LineRange {
}
}

#[allow(dead_code)]
pub fn overlaps(&self, other: &LineRange) -> bool {
match (self, other) {
(LineRange::Single(l1), LineRange::Single(l2)) => l1 == l2,
(LineRange::Single(l), LineRange::Range(start, end)) => *l >= *start && *l <= *end,
(LineRange::Range(start, end), LineRange::Single(l)) => *l >= *start && *l <= *end,
(LineRange::Range(start1, end1), LineRange::Range(start2, end2)) => {
start1 <= end2 && start2 <= end1
}
}
}

/// Remove a line or range from this range, returning the remaining parts
#[allow(dead_code)]
pub fn remove(&self, to_remove: &LineRange) -> Vec<LineRange> {
match (self, to_remove) {
(LineRange::Single(l), LineRange::Single(r)) => {
Expand Down Expand Up @@ -125,7 +112,6 @@ impl LineRange {
ranges
}

#[allow(dead_code)]
pub fn expand(&self) -> Vec<u32> {
match self {
LineRange::Single(l) => vec![*l],
Expand All @@ -137,7 +123,6 @@ impl LineRange {
/// - For insertions: offset is positive (shift lines down/forward)
/// - For deletions: offset is negative (shift lines up/backward)
/// - insertion_point: the line number where the change occurred
#[allow(dead_code)]
pub fn shift(&self, insertion_point: u32, offset: i32) -> Option<LineRange> {
// Helper: apply offset to a line number, returning None if result is negative
let apply_offset = |line: u32| -> Option<u32> {
Expand Down
16 changes: 0 additions & 16 deletions src/authorship/working_log.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,18 +60,6 @@ impl fmt::Display for CheckpointKind {
}

impl CheckpointKind {
#[allow(dead_code)]
#[allow(clippy::should_implement_trait)]
pub fn from_str(s: &str) -> Self {
match s {
"human" => CheckpointKind::Human,
"ai_agent" => CheckpointKind::AiAgent,
"ai_tab" => CheckpointKind::AiTab,
"known_human" => CheckpointKind::KnownHuman,
_ => panic!("Invalid checkpoint kind: {}", s),
}
}

#[allow(clippy::wrong_self_convention)]
pub fn to_str(&self) -> String {
match self {
Expand Down Expand Up @@ -254,10 +242,6 @@ mod tests {
fn test_checkpoint_kind_known_human_roundtrip() {
let kind = CheckpointKind::KnownHuman;
assert_eq!(kind.to_str(), "known_human");
assert_eq!(
CheckpointKind::from_str("known_human"),
CheckpointKind::KnownHuman
);
// Serde round-trip
let json = serde_json::to_string(&kind).unwrap();
let back: CheckpointKind = serde_json::from_str(&json).unwrap();
Expand Down
Loading