Cache trig and combine deg2rad in heading()#16
Merged
Conversation
MrHerrn
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize
heading()hot-pathTwo micro-optimizations in
geo::heading()— it's called in every bearing calculation, so each saved instruction adds up.Combine two
deg2radcalls into oneInstead of converting
from.lngandto.lngseparately and subtracting, computedeg2rad(to.lng - from.lng). Algebraically identical (a*k - b*k == (a - b)*k), one fewer multiplication, and the from-side longitude is no longer needed in radians at all.Cache
sin/cosof latitudescos(to_lat),sin(to_lat),cos(from_lat),sin(from_lat)each appeared twice in theatan2arguments. Without-ffast-math, the compiler is not allowed to CSE calls tostd::sin/std::cosbecause they may touch the floating-point environment (errno, FE flags). Storing them in locals forces a single libm call per value — cuts trig calls in this function from 8 to 4.Behavior is unchanged — codegen only