Skip to content

[wasm] Bump chrome for testing - linux: 119.0.6045.105, windows: 119.0.6045.105 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[wasm] Bump chrome for testing - linux: 119.0.6045.105, windows: 119.0.6045.105 #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43387ee
Fixing endianess issues on S390x
Nov 3, 2023
e7f7539
Automated bump of chrome version
github-actions[bot] Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions eng/testing/ChromeVersions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<Project>
<PropertyGroup>
<linux_ChromeVersion>118.0.5993.117</linux_ChromeVersion>
<linux_ChromeRevision>1192594</linux_ChromeRevision>
<linux_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1192597</linux_ChromeBaseSnapshotUrl>
<linux_V8Version>11.8.172</linux_V8Version>
<linux_ChromeVersion>119.0.6045.105</linux_ChromeVersion>
<linux_ChromeRevision>1204232</linux_ChromeRevision>
<linux_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1204234</linux_ChromeBaseSnapshotUrl>
<linux_V8Version>11.9.169</linux_V8Version>

<win_ChromeVersion>119.0.6045.59</win_ChromeVersion>
<win_ChromeVersion>119.0.6045.105</win_ChromeVersion>
<win_ChromeRevision>1204232</win_ChromeRevision>
<win_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1204234</win_ChromeBaseSnapshotUrl>
<win_V8Version>11.9.169</win_V8Version>
Expand Down
16 changes: 11 additions & 5 deletions ...s/System.Reflection.Emit/tests/PersistableAssemblyBuilder/AssemblySaveILGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System.IO;
using System.Linq;
using Xunit;
using System.Buffers.Binary;

namespace System.Reflection.Emit.Tests
{
Expand Down Expand Up @@ -423,7 +424,8 @@ public void LocalBuilderMultipleLocalsUsage()
Assert.Equal((byte)OpCodes.Ldarg_0.Value, bodyBytes[11]);
Assert.Equal((byte)OpCodes.Stloc_0.Value, bodyBytes[12]);
Assert.Equal((byte)OpCodes.Ldc_I4_S.Value, bodyBytes[13]);
Assert.Equal(120, BitConverter.ToInt32(bodyBytes.AsSpan().Slice(14, 4)));
//Assert.Equal(120, BitConverter.ToInt32(bodyBytes.AsSpan().Slice(14, 4)));
Assert.Equal(120, ReadInt32LittleEndian(bodyBytes.AsSpan().Slice(14, 4)));
Assert.Equal(0xFE, bodyBytes[18]); // Stloc instruction occupies 2 bytes 0xfe0e
Assert.Equal(0x0E, bodyBytes[19]);
Assert.Equal(2, BitConverter.ToInt32(bodyBytes.AsSpan().Slice(20, 4))); // index 2 of 'il.Emit(OpCodes.Stloc, 2);' instruction
Expand Down Expand Up @@ -568,7 +570,8 @@ public void ReferenceFieldInIL()
Assert.NotEqual(0, fbNumber.MetadataToken);
Assert.Equal(OpCodes.Ldarg_0.Value, bodyBytes[0]);
Assert.Equal(OpCodes.Ldfld.Value, bodyBytes[1]);
Assert.Equal(fbNumber.MetadataToken, BitConverter.ToInt32(bodyBytes.AsSpan().Slice(2, 4)));
//Assert.Equal(fbNumber.MetadataToken, BitConverter.ToInt32(bodyBytes.AsSpan().Slice(2, 4)));
Assert.Equal(fbNumber.MetadataToken, ReadInt32LittleEndian(bodyBytes.AsSpan().Slice(2, 4)));
Assert.Equal(OpCodes.Ldarg_1.Value, bodyBytes[6]);
Assert.Equal(OpCodes.Mul.Value, bodyBytes[7]);
Assert.Equal(OpCodes.Ret.Value, bodyBytes[8]);
Expand Down Expand Up @@ -632,7 +635,8 @@ void Main(int a)
Assert.Equal(OpCodes.Ldstr.Value, bodyBytes[10]);
Assert.Equal(OpCodes.Ldarg_0.Value, bodyBytes[15]);
Assert.Equal(OpCodes.Ldfld.Value, bodyBytes[16]);
Assert.Equal(field.MetadataToken, BitConverter.ToInt32(bodyBytes.AsSpan().Slice(17, 4)));
//Assert.Equal(field.MetadataToken, BitConverter.ToInt32(bodyBytes.AsSpan().Slice(17, 4)));
Assert.Equal(field.MetadataToken, ReadInt32LittleEndian(bodyBytes.AsSpan().Slice(17, 4)));
Assert.Equal(OpCodes.Box.Value, bodyBytes[21]);
int intTypeToken = BitConverter.ToInt32(bodyBytes.AsSpan().Slice(22, 4));
Assert.Equal(OpCodes.Ldarg_1.Value, bodyBytes[26]);
Expand Down Expand Up @@ -679,7 +683,8 @@ public void EmitWriteLineMacroTest()
Assert.Equal(OpCodes.Stloc_0.Value, bodyBytes[1]);
Assert.Equal(OpCodes.Ldloc_0.Value, bodyBytes[2]);
Assert.Equal(OpCodes.Stsfld.Value, bodyBytes[3]);
Assert.Equal(field.MetadataToken, BitConverter.ToInt32(bodyBytes.AsSpan().Slice(4, 4)));
//Assert.Equal(field.MetadataToken, BitConverter.ToInt32(bodyBytes.AsSpan().Slice(4, 4)));
Assert.Equal(field.MetadataToken, ReadInt32LittleEndian(bodyBytes.AsSpan().Slice(4, 4)));
Assert.Equal(OpCodes.Call.Value, bodyBytes[8]);
Assert.Equal(OpCodes.Ldsfld.Value, bodyBytes[13]);
Assert.Equal(field.MetadataToken, BitConverter.ToInt32(bodyBytes.AsSpan().Slice(14, 4)));
Expand Down Expand Up @@ -734,7 +739,8 @@ void static StaticMethod() { }
Type typeFromDisk = assemblyFromDisk.Modules.First().GetType("MyType");
byte[]? bodyBytes = typeFromDisk.GetMethod("Main").GetMethodBody().GetILAsByteArray();
Assert.Equal(OpCodes.Call.Value, bodyBytes[0]);
Assert.Equal(staticMethod.MetadataToken, BitConverter.ToInt32(bodyBytes.AsSpan().Slice(1, 4)));
//Assert.Equal(staticMethod.MetadataToken, BitConverter.ToInt32(bodyBytes.AsSpan().Slice(1, 4)));
Assert.Equal(staticMethod.MetadataToken, ReadInt32LittleEndian(bodyBytes.AsSpan().Slice(1, 4)));
Assert.Equal(OpCodes.Ldarg_1.Value, bodyBytes[5]);
Assert.Equal(OpCodes.Stsfld.Value, bodyBytes[6]);
Assert.Equal(field.MetadataToken, BitConverter.ToInt32(bodyBytes.AsSpan().Slice(7, 4)));
Expand Down