Allow enabling checksums without recompiling #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces AzureBlobChecksumTusStore, inheriting from AzureBlobTusStore and implementing ITusChecksumStore. This refactors checksum support into a dedicated class, removing conditional compilation for ITusChecksumStore from AzureBlobTusStore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make use of checksums from the Nuget package and without the need to recompile the project I propose moving away from the precompiler directive and instead use inheritance to enable the checksum.
This PR introduces the
AzureBlobChecksumTusStoreclass which simply inherits fromAzureBlobTusStoreand implementsITusChecksumStore. The end use can the enable the checksum extension by usingAzureBlobChecksumTusStoreinstead ofAzureBlobTusStore.TusDotNet's StoreAdapter will test the provided store for extension capability. Since C# is nominally typed,
AzureBlobTusStorewon't support checksums butAzureBlobChecksumTusStorewill.Documentation has been updated to reflect this change.
I appreciate your work on this package so far. Please let me know of any changes you would like.