This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Allow protocol to be set at the container level#156
Open
IanMoroney wants to merge 1 commit intogimlet-io:masterfrom
Open
Allow protocol to be set at the container level#156IanMoroney wants to merge 1 commit intogimlet-io:masterfrom
IanMoroney wants to merge 1 commit intogimlet-io:masterfrom
Conversation
Author
|
@laszlocph , or @youcefguichi , could you review and merge if possible? this is blocking me on something today |
Author
|
A new release for this would also be appreciated |
Author
|
@laszlocph or @youcefguichi , is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To accommodate traffic for different protocols at the container level, the protocol should be allowed to be set in the same way it's done at the service level, and default to TCP for backward compatibility.