add custom service account#19
Merged
QuantumEnigmaa merged 5 commits intomainfrom Nov 18, 2025
Merged
Conversation
QuentinBisson
approved these changes
Nov 17, 2025
Contributor
There was a problem hiding this comment.
What's happening with the schéma? Can you add a comment linking the upstream issue?
Do we have a way to communicate with upstream ?
Contributor
Author
There was a problem hiding this comment.
What's happening with the schéma?
WDYM ? It looks alright to me 🤔
Can you add a comment linking the upstream issue?
Done ✔️
Do we have a way to communicate with upstream ?
I am in contact with one of the maintainers on Slack but he didn't respond yet
Contributor
Author
There was a problem hiding this comment.
Ooooh that was a file I created by mistake sorry. Removed it
QuentinBisson
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/33500
This is needed for IRSA until the upstream PR is merged and allow to add additional annotations to the service account alone.
Checklist
values.yamlandvalues.schema.jsonare valid.