Fixing weth decoder with a separate commit, risk of regressions.#1
Open
gianluca-pub-dev wants to merge 4 commits into
Open
Conversation
…eterministic decoding.
This time not coming from a bug
Imho event address should be related to WETH address, if not the event sense is not clear
Owner
Author
|
Hello @LefterisJP , this is another change I would propose for having the unwrapping operation always tracked with the WETH contract. Without this, I have seen that address is sometime the DSProxy address, some other times another contract address used in the transaction, and other cases. I think it is more clear and maintenable in this way. I kept this modification separated in another repo for not creating problems with others already existing test cases. |
gianluca-pub-dev
force-pushed
the
bugfix/makerdao_eth_vaults_asset_type
branch
from
32b528e to
1cc4edf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imho event address should be related to WETH address, if not the event address is not clear. You can see from test cases that without this modification, the WETH unwrap operation was mapped to unrelated contract addresses
Closes #(issue_number)
Checklist