feat: generated sql.gleam files now include parent directory in name#88
Open
ross-byrne wants to merge 3 commits intogiacomocavalieri:mainfrom
Open
feat: generated sql.gleam files now include parent directory in name#88ross-byrne wants to merge 3 commits intogiacomocavalieri:mainfrom
ross-byrne wants to merge 3 commits intogiacomocavalieri:mainfrom
Conversation
ross-byrne
force-pushed
the
71-rename-modules
branch
from
9d9a605 to
cd0b317
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #71
I've added a unit test but there isn't a whole lot of testing around file generation in general. Maybe more tests could be added in a follow up.
I've also updated the documentation and changelog, feel free to suggest edits as I'm not 100% on the wording. We might have to update the video in the readme but that can be done separately.