Use shared test suites for KVStore providers (GSI-2093) #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 21222309694Details
💛 - Coveralls |
TheByronHimes
previously approved these changes
Jan 21, 2026
Member
TheByronHimes
left a comment
TheByronHimes
left a comment
There was a problem hiding this comment.
This is a neat idea. Thanks for putting it together.
| return dto_kvstore | ||
|
|
||
| @pytest.fixture() | ||
| def test_value(self) -> SimpleDto: |
Member
There was a problem hiding this comment.
Should this be named something other than test_ to avoid confusion with the pytest naming convention?
|
|
||
| from hexkit.custom_types import JsonObject | ||
| from hexkit.protocols.kvstore import KeyValueStoreProtocol | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| pytestmark = pytest.mark.asyncio() |
Then you can remove all instances of @pytest.mark.asyncio below
Member
Author
There was a problem hiding this comment.
Yes, it's really worth it in this case. Done in 957eda7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of the provider test refactoring.
We use a shared module to hold test suites for all variants of the KV providers. The provider specific test modules then only need to contain provider specific fixtures and white box testing. This also guarantees that all provides share the same behavior.