Redis-based KV-store (GSI-2087) #208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 20964357707Details
💛 - Coveralls |
TheByronHimes
previously approved these changes
Jan 13, 2026
Member
TheByronHimes
left a comment
TheByronHimes
left a comment
There was a problem hiding this comment.
No major issues, just a few small questions
TheByronHimes
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on PR #207, so that should be reviewed first.
The integration tests for the two providers now look pretty much alike and there is a lot of duplication, which is getting worse when we will add more kv store providers. To ease this, I think we need to restructure the integrations tests, with the protocol as top level and provider as second level, and then reuse tests (parametrizing the fixtures). This will be done in a separate PR, so please ignore the duplication in this PR.