Support limited nosql for InMemDao (GSI-2080) #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cito
requested changes
Jan 7, 2026
Member
Cito
left a comment
Cito
left a comment
There was a problem hiding this comment.
Would be good to make it a bit more powerful if we already support that.
Maybe we can then require all DAO providers to support that same subset of MSQL supported by the InMemDao. The subseet should stay minimal of course, but not so minimal as in the current inplementation.
Pull Request Test Coverage Report for Build 20862335402Details
💛 - Coveralls |
Also remove neq operator because it's not real
Cito
requested changes
Jan 9, 2026
Member
Cito
left a comment
Cito
left a comment
There was a problem hiding this comment.
Looks good overall. I don't think we should support more operators.
Some suggestions for improvement below.
tests/integration/mongodb/test_in_mem_dao_against_actual_mongo.py
Outdated
Show resolved
Hide resolved
Cito
reviewed
Jan 9, 2026
…a real DB Fix nesting Make sure $exists works with nested fields
Cito
approved these changes
Jan 12, 2026
TheByronHimes
deleted the
feature/support_limited_nosql_in_tests_GSI-2080
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The InMemDao speeds up testing by allowing us to forgo the weighty mongo testcontainers. One hangup, though, is that they only support querying by direct equivalence mappings. Since some of our services use queries that employ Mongo Query Language comparison operators, e.g.
$inor$gt, the InMemDao wasn't usable in every case. This PR adds support for MQL comparison operators for the InMemDao, and is written in a way to allow us to add other operator categories in the future and group them as such with the thinking that this makes it easier to extend.Bumps version to
7.3.0