Made examples and demo optional build options in cmake#5
Open
SleepProgger wants to merge 1 commit intoghaerr:masterfrom
Open
Made examples and demo optional build options in cmake#5SleepProgger wants to merge 1 commit intoghaerr:masterfrom
SleepProgger wants to merge 1 commit intoghaerr:masterfrom
Conversation
Owner
|
Hello @SleepProgger, Thanks for the PR! I've been a bit buried in other work but hope to be able to review this and get it committed soon. I myself haven't used CMake on this project, but your changes look useful for those who do.
I'll reach out... there have been few changes on Sourceforge in the last couple years, almost all small changes, nothing functional. I have been thinking of updating this repo with those changes as well. Thank you! |
xakod
approved these changes
Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added following build options to make building as subproject a bit more comfortable.
agg_BUILD_EXAMPLESagg_BUILD_DEMOagg_BUILD_PLATFORMagg_BUILD_CONTROLSagg_BUILD_PLATFORMandagg_BUILD_CONTROLSare forced to true if eitheragg_BUILD_EXAMPLESoragg_BUILD_DEMOare set.So by default nothing should have changed as examples and the demo are defaulting to ON.
Not sure this is of interest for you, but it can't harm to try to get it "upstream".