Skip to content

whisper: validate mel filter dimensions to prevent integer overflow #3780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sebasteuo wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −1
Open

whisper: validate mel filter dimensions to prevent integer overflow #3780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/whisper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1580,7 +1580,23 @@ static bool whisper_model_load(struct whisper_model_loader * loader, whisper_con
read_safe(loader, filters.n_mel);
read_safe(loader, filters.n_fft);

filters.data.resize(filters.n_mel * filters.n_fft);
// Validate dimensions to prevent integer overflow in the resize() multiplication
// below and to ensure consistency with hparams.n_mels.
if (filters.n_mel <= 0 || filters.n_mel > 1024 ||
filters.n_fft <= 0 || filters.n_fft > WHISPER_N_FFT) {
WHISPER_LOG_ERROR("%s: invalid mel filter dimensions (n_mel=%d, n_fft=%d)\n",
__func__, filters.n_mel, filters.n_fft);
return false;
}

if (filters.n_mel != hparams.n_mels) {
WHISPER_LOG_ERROR("%s: mel filter n_mel=%d does not match hparams n_mels=%d\n",
__func__, filters.n_mel, hparams.n_mels);
return false;
}

const size_t total_size = (size_t)filters.n_mel * (size_t)filters.n_fft;
filters.data.resize(total_size);
loader->read(loader->context, filters.data.data(), filters.data.size() * sizeof(float));
BYTESWAP_FILTERS(filters);
}
Expand Down
Loading