ggml-cpu: fix _pdep_u64 usage on Linux x86 32-bit#3768
Open
Kabir08 wants to merge 2 commits into
Open
Conversation
_pdep_u64 is a BMI2 intrinsic only available in 64-bit (x86_64) mode.
On 32-bit i386 with BMI2, only _pdep_u32 exists. The previous guard
'#ifdef __BMI2__' was insufficient and produced wrong results on Linux 32-bit.
Fix both occurrences in ggml_vec_dot_iq1_s_q8_K and
ggml_vec_dot_iq1_m_q8_K to use:
#if defined(__BMI2__) && defined(__x86_64__)
This ensures 32-bit builds use the scalar fallback paths.
Fixes: ggml-org#3758
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_pdep_u64 is a BMI2 intrinsic only available in 64-bit (x86_64) mode. On 32-bit i386 with BMI2, only _pdep_u32 exists. The previous guard '#ifdef BMI2' was insufficient and produced wrong results on Linux 32-bit.
Fix both occurrences in ggml_vec_dot_iq1_s_q8_K and ggml_vec_dot_iq1_m_q8_K to use:
#if defined(BMI2) && defined(x86_64)
This ensures 32-bit builds use the scalar fallback paths.
Fixes: #3758