Skip to content

whisper : validate vocab size and per-token length when loading model (#3674) #3767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
achyutbenz19 wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −5
Open

whisper : validate vocab size and per-token length when loading model (#3674) #3767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions src/whisper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1587,14 +1587,22 @@ static bool whisper_model_load(struct whisper_model_loader * loader, whisper_con

// load vocab
{
// Upper bounds for values read from untrusted model files. A malformed
// or fuzzed file can otherwise set these to values that cause
// std::vector::resize to throw (bad_alloc) or std::string to terminate
// the process with SIGABRT during vocab construction.
// ref: https://github.com/ggml-org/whisper.cpp/issues/3674
constexpr int32_t max_n_vocab = 1 << 20; // ~1M tokens (largest real models are ~52k)
constexpr uint32_t max_word_len = 1 << 16; // 64 KiB per vocab token

int32_t n_vocab = 0;
read_safe(loader, n_vocab);

//if (n_vocab != model.hparams.n_vocab) {
// WHISPER_LOG_ERROR("%s: invalid model file '%s' (bad vocab size %d != %d)\n",
// __func__, fname.c_str(), n_vocab, model.hparams.n_vocab);
// return false;
//}
if (n_vocab < 0 || n_vocab > max_n_vocab) {
WHISPER_LOG_ERROR("%s: invalid vocab size %d (expected 0..%d); malformed model file\n",
__func__, n_vocab, max_n_vocab);
return false;
}

std::string word;
std::vector<char> tmp;
Expand All @@ -1605,6 +1613,12 @@ static bool whisper_model_load(struct whisper_model_loader * loader, whisper_con
uint32_t len;
read_safe(loader, len);

if (len > max_word_len) {
WHISPER_LOG_ERROR("%s: invalid vocab entry %d length %u (max %u); malformed model file\n",
__func__, i, len, max_word_len);
return false;
}

if (len > 0) {
tmp.resize(len);
loader->read(loader->context, &tmp[0], tmp.size()); // read to buffer
Expand Down