common: load parser in common_chat_parser_params constructor#21659
Open
sacredvoid wants to merge 1 commit intoggml-org:masterfrom
Open
common: load parser in common_chat_parser_params constructor#21659sacredvoid wants to merge 1 commit intoggml-org:masterfrom
sacredvoid wants to merge 1 commit intoggml-org:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
common_chat_parser_paramscopiesformatandgeneration_promptfromcommon_chat_paramsbut never callsparser.load(). Without that call,common_chat_parse()falls back to a content-only parser, so tool calls end up inmsg.contentinstead ofmsg.tool_calls. The server works around this by loading the parser separately, but anyone using the library directly hits this bug.Adds the missing
parser.load()call in the constructor (3 lines) and a test that verifies the constructor path parses tool calls end-to-end.Additional information
Fixes #21650
Requirements