ggml-webgpu: Update register tiling matmul to use f32 accumulation#21644
Open
reeselevine wants to merge 3 commits intoggml-org:masterfrom
Open
ggml-webgpu: Update register tiling matmul to use f32 accumulation#21644reeselevine wants to merge 3 commits intoggml-org:masterfrom
reeselevine wants to merge 3 commits intoggml-org:masterfrom
Conversation
Contributor
|
The f32 accumulator fix seems to be helping us. I hooked this branch with wllama and ran the Qwen models; it seems to be working as expected on Firefox and Safari now. Chrome still seems to be broken, but it's no longer printing Chrome output: |
github-actions
bot
added
ggml
Contributor
Now it works on Chrome as well!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Partially fixes issue here: #21602
Also fixes issue compiling with WebGPU GPU profiling turned on.
Requirements