macros/python: Remove python2 macros and add pyproject macros#142
Open
EbonJaeger wants to merge 1 commit into
Open
macros/python: Remove python2 macros and add pyproject macros#142EbonJaeger wants to merge 1 commit into
EbonJaeger wants to merge 1 commit into
Conversation
Signed-off-by: Evan Maddock <maddock.evan@vivaldi.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Now that Solus no longer supports anything Python 2, we can remove the old Python 2 macros.
This also addresses an old annoyance where our Python macros try to be a do-all that support PEP517 and non-PEP517 in the same invocation. Some software doesn't play nice and ship files indicating both ways, which confuses the macro, and the wrong commands are run. Making the pyproject macros explicit eliminates having to do things like
rm setup.pyorrm pyproject.tomlduring the package build.Another very common pattern in packages is
%python3_test pytest. We can shorten that by having just a%pytestmacro.Lastly, adding
%python3_sitepackages%GREATLY shortens lines in package files that currently have to specify the entire path manually.Test Plan
Build
reusewith all of the new macros, and see that the resulting.eopkgfile contains the correct files in the correct paths.