Skip to content

build(test-django-rest-framework-streaming): Migrate to uv and pyproject.toml#17

Merged
ericapisani merged 1 commit into
mainfrom
PY-2444-test-django-rest-framework-streaming
May 21, 2026
Merged

build(test-django-rest-framework-streaming): Migrate to uv and pyproject.toml#17
ericapisani merged 1 commit into
mainfrom
PY-2444-test-django-rest-framework-streaming

Conversation

@ericapisani

Copy link
Copy Markdown
Member

Summary

  • Replace pip/requirements.txt with uv/pyproject.toml for dependency management
  • Update run.sh to use uv run instead of manual venv creation and pip install
  • Remove legacy requirements.txt

Refs PY-2444

Test plan

  • Verify pyproject.toml includes all dependencies from the original requirements.txt
  • Verify run.sh uses uv run
  • Verify requirements.txt is removed

🤖 Generated with Claude Code

…ect.toml

Replace pip/requirements.txt with uv/pyproject.toml for dependency
management. Update run.sh to use uv run instead of manual venv
creation and pip install.

Refs PY-2444
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@linear-code

linear-code Bot commented May 21, 2026

Copy link
Copy Markdown

PY-2444

[project]
name = "test-django-rest-framework-streaming"
version = "0"
requires-python = ">=3.12"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The pyproject.toml requires Python >=3.12, but the .python-version file is pinned to 3.11. This conflict will cause uv to fail, preventing the app from starting.
Severity: CRITICAL

Suggested Fix

Align the Python version requirements. Either update the .python-version file to a version that satisfies >=3.12 (e.g., 3.12), or adjust the requires-python constraint in pyproject.toml to ">=3.11" to match the existing environment.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: test-django-rest-framework-streaming/pyproject.toml#L4

Potential issue: The `pyproject.toml` file specifies `requires-python = ">=3.12"`, while
the existing `.python-version` file in the same directory pins the Python version to
`3.11`. When the `run.sh` script executes `uv run gunicorn mysite.wsgi:application`, the
`uv` tool will detect this version incompatibility and exit with an error. Because
`run.sh` is configured with `set -euo pipefail`, the script will terminate immediately
upon this error, preventing the Gunicorn server from ever launching and the application
from starting.

Did we get this right? 👍 / 👎 to inform future reviews.

@ericapisani ericapisani merged commit f24f7d0 into main May 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant