build(test-django-debug-toolbar): Migrate to uv and pyproject.toml#16
Merged
Conversation
Replace pip/requirements.txt with uv/pyproject.toml for dependency management. Update run.sh to use uv run instead of manual venv creation and pip install. Refs PY-2443 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| # Run Django application on localhost:8000 | ||
| ./manage.py runserver 0.0.0.0:8000 | ||
| #gunicorn movie_search.project.asgi:application -k uvicorn.workers.UvicornWorker No newline at end of file | ||
| uv run ./manage.py runserver 0.0.0.0:8000 |
There was a problem hiding this comment.
Bug: The run.sh script calls ./manage.py from the wrong directory. It needs to change into the mysite subdirectory before executing the command.
Severity: HIGH
Suggested Fix
Update the script to change the current directory to mysite before running the manage.py command. A similar project uses cd mysite && uv run python ./manage.py runserver 0.0.0.0:8000 && cd .. which would resolve the issue.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: test-django-debug-toolbar/run.sh#L8
Potential issue: The `run.sh` script attempts to execute `uv run ./manage.py runserver
0.0.0.0:8000` from the `test-django-debug-toolbar/` directory. However, the `manage.py`
file is actually located within the `test-django-debug-toolbar/mysite/` subdirectory.
Because the path is incorrect, the script will fail at runtime with a 'No such file or
directory' error when it tries to find `manage.py`.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pip/requirements.txtwithuv/pyproject.tomlfor dependency managementrun.shto useuv runinstead of manual venv creation and pip installrequirements.txtRefs PY-2443
Test plan
pyproject.tomlincludes all dependencies from the originalrequirements.txtrun.shusesuv runrequirements.txtis removed🤖 Generated with Claude Code