Skip to content

test(migrations): Deflake test_reverse_idempotency_all #8038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phacops merged 1 commit into from
Jun 16, 2026
+11 −7
Merged

test(migrations): Deflake test_reverse_idempotency_all #8038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions tests/migrations/test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,13 +351,17 @@ def reverse_twice() -> None:
ClickhouseClientSettings.MIGRATE
)

before_state = cluster_connection.execute(
"SELECT create_table_query FROM system.tables"
).results
# `system.tables` has no guaranteed row order, and the
# reverse_twice() cycle in between can perturb the order rows
# are returned in (e.g. ON CLUSTER DDL re-registering tables).
# Order the snapshots so the comparison reflects the set of
# tables and their definitions, not the iteration order.
snapshot_query = (
"SELECT create_table_query FROM system.tables ORDER BY create_table_query"
)
before_state = cluster_connection.execute(snapshot_query).results
reverse_twice()
after_state = cluster_connection.execute(
"SELECT create_table_query FROM system.tables"
).results
after_state = cluster_connection.execute(snapshot_query).results
assert before_state == after_state
except UndefinedClickhouseCluster:
# Some groups do not have a cluster defined (e.g. test_migration)
Expand Down Expand Up @@ -489,7 +493,7 @@ def test_check_inactive_replica() -> None:
with pytest.raises(InactiveClickhouseReplica) as exc:
check_for_inactive_replicas([mock_cluster])

assert exc.value.args[0] == (
assert str(exc.value) == (
"Cluster test_cluster has inactive replicas for table bad_table_1 "
"with 2 out of 3 replicas active.\n"
"Cluster test_cluster has inactive replicas for table bad_table_2 "
Expand Down
Loading