fix(gocd): remove s4s, mattrobenolt-kube references from pipelines and code#7875
Merged
phacops merged 4 commits intoJun 16, 2026
Merged
Conversation
…d code S4S (sentry4sentry) is no longer used. This removes: - s4s health check bash scripts - s4s_health_check functions from GoCD pipeline templates - Updates PIPELINE_FIRST_STEP to reference `us` instead of `s4s` - Cleans up stale s4s/mattrobenolt-kube references in comments Made-with: Cursor
mwarkentin
commented
Apr 15, 2026
| self.max_batch_size, | ||
| self.max_batch_time, | ||
| compute_batch_size, | ||
| // we need to enable this to deal with storages where we skip 100% of values, such as |
Member
Author
There was a problem hiding this comment.
Maybe this means we can update the code? Not sure if there are non-s4s places where this applied.
mwarkentin
commented
Apr 15, 2026
mwarkentin
commented
Apr 15, 2026
Co-authored-by: Michael Warkentin <mwarkentin@hey.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 05ff680. Configure here.
xurui-c
approved these changes
May 4, 2026
…odeng-738-remove-s4s-from-gocd-pipelines
s4s2 is the intended first step for deploy checks, so keep the PIPELINE_FIRST_STEP values and point the manual-run default at the same pipeline for consistency. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Agent transcript: https://claudescope.sentry.dev/share/1GgNiDkThy4ES81W_CBJKDhvBsmnd5GutiO5foFrXiw
phacops
approved these changes
Jun 16, 2026
phacops
deleted the
michaelwarkentin/prodeng-738-remove-s4s-from-gocd-pipelines
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We killed s4s today, here's my attempt at getting claude to clean up references.. feel free to tear it apart.
Summary
PIPELINE_FIRST_STEPto referenceusinstead ofs4sin both snuba-py and snuba-rs pipelinesmattrobenolt-kubehostname in a trace log parsing example commentTest plan
check-migrations.shworks with the updatedPIPELINE_FIRST_STEPvaluesMade with Cursor