Draft
Conversation
github-actions
bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CacheAccess is ok for single key interactions, but it makes bulk operations (which should in many cases be the default) painful.
CacheMapping is a bit more intuitive, offers safe(ish) bulk operations, and can generate a CacheAccess when single-item interaction is more convenient.
This also has a concept of namespacing; we had a bug in the past where two cache interactions were unintentionally using the same prefix. By using module-level CacheMapping with the namespace explicitly provided, this should be a non-issue. It's not perfect, but the more is provided at framework level, the more leeway we have to validate this sort of thing.