ref(grouping): Parameterize messages in custom fingerprints#107808
Open
lobsterkatie wants to merge 2 commits intomasterfrom
Open
ref(grouping): Parameterize messages in custom fingerprints#107808lobsterkatie wants to merge 2 commits intomasterfrom
lobsterkatie wants to merge 2 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
shashjar
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we group events based on either a log message (from
captureMessage) or an error message, we first do our best to parameterize them, so thatError with user 1andError with user 2don't create separate groups. The same is not true, however, if that message appears as part of a custom fingerprint. This PR fixes that, by using the samenormalize_message_for_groupinghelper that we use in the first two cases in the latter case.Note: Since prior to this change messages in fingerprints haven't been getting trimmed, this change preserves that behavior by setting
trim_messagetoFalse. This is different from what we do when we're grouping log or error message directly, but means that message-containing fingerprints unaffected by parameterization won't change as a result of this PR.