ref(scraps) simplify avatar component #107799
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| import {render, screen} from 'sentry-test/reactTestingLibrary'; | ||
|
|
||
| // eslint-disable-next-line boundaries/entry-point | ||
| import {Avatar} from './avatar'; | ||
|
|
||
| describe('Avatar', () => { | ||
| describe('upload URL size parameter', () => { | ||
| it('appends ?s=120 to upload URLs', () => { | ||
| render( | ||
| <Avatar | ||
| type="upload" | ||
| uploadUrl="https://example.com/avatar.jpg" | ||
| identifier="test-id" | ||
| name="Test User" | ||
| /> | ||
| ); | ||
| const img = screen.getByRole('img'); | ||
| expect(img).toHaveAttribute('src', 'https://example.com/avatar.jpg?s=120'); | ||
| }); | ||
|
|
||
| it('appends &s=120 to upload URLs with existing query params', () => { | ||
| render( | ||
| <Avatar | ||
| type="upload" | ||
| uploadUrl="https://example.com/avatar.jpg?version=2" | ||
| identifier="test-id" | ||
| name="Test User" | ||
| /> | ||
| ); | ||
| const img = screen.getByRole('img'); | ||
| expect(img).toHaveAttribute( | ||
| 'src', | ||
| 'https://example.com/avatar.jpg?version=2&s=120' | ||
| ); | ||
| }); | ||
|
|
||
| it('does not modify data URLs', () => { | ||
| const dataUrl = | ||
| 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mNk+M9QDwADhgGAWjR9awAAAABJRU5ErkJggg=='; | ||
| render( | ||
| <Avatar type="upload" uploadUrl={dataUrl} identifier="test-id" name="Test User" /> | ||
| ); | ||
| const img = screen.getByRole('img'); | ||
| // Data URLs should not have size parameter appended | ||
| expect(img).toHaveAttribute('src', dataUrl); | ||
| }); | ||
| }); | ||
|
|
||
| describe('avatar type rendering', () => { | ||
| it('renders ImageAvatar for upload type', () => { | ||
| render( | ||
| <Avatar | ||
| type="upload" | ||
| uploadUrl="https://example.com/avatar.jpg" | ||
| identifier="test-id" | ||
| name="Test User" | ||
| /> | ||
| ); | ||
| expect(screen.getByRole('img')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('renders LetterAvatar for letter_avatar type', () => { | ||
| render(<Avatar type="letter_avatar" identifier="test-id" name="Test User" />); | ||
| expect(screen.getByText('TU')).toBeInTheDocument(); | ||
| expect(screen.queryByRole('img')).not.toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('renders Gravatar for gravatar type', async () => { | ||
| render( | ||
| <Avatar | ||
| type="gravatar" | ||
| gravatarId="test@example.com" | ||
| identifier="test-id" | ||
| name="Test User" | ||
| /> | ||
| ); | ||
| // Gravatar hashes asynchronously, so use findBy | ||
| expect(await screen.findByRole('img')).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
|
|
||
| describe('tooltip', () => { | ||
| it('shows tooltip when hasTooltip=true', () => { | ||
| render( | ||
| <Avatar | ||
| type="letter_avatar" | ||
| identifier="test-id" | ||
| name="Test User" | ||
| tooltip="Test Tooltip" | ||
| hasTooltip | ||
| /> | ||
| ); | ||
| expect(screen.getByText('TU')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('does not show tooltip when hasTooltip=false', () => { | ||
| render( | ||
| <Avatar | ||
| type="letter_avatar" | ||
| identifier="test-id" | ||
| name="Test User" | ||
| tooltip="Test Tooltip" | ||
| hasTooltip={false} | ||
| /> | ||
| ); | ||
| expect(screen.getByText('TU')).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UX here is unnecessary and confusing. We already indicate in the option that users can control their gravatar at gravatar.com, and there is no reason to display a upload and a change button that do the same thing