fix(typing): Fix order_by column type handling in base_query_set#107790
Draft
fix(typing): Fix order_by column type handling in base_query_set#107790
Conversation
github-actions
bot
added
the
Scope: Backend
Narrow `col` with `isinstance(col, str)` before passing to `query.annotations.get()`, and type `new_order_by` as `list[str | Combinable]` to properly handle both branches. Ref: #107727
JoshFerge
force-pushed
the
jferg/fix-typing-base-query-set
branch
from
062a7fa to
ff74257
Compare
JoshFerge
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
colwithisinstance(col, str)before passing toquery.annotations.get(), sincequery.order_bycontainsstr | Combinablenew_order_byaslist[str | Combinable]to properly handle both branchesRef: #107710