-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(onboarding): Metrics page for .NET platforms #106552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f3ad0c7
feat(onboarding): Metrics page for .NET platforms
alexander-alderman-webb c2f8de8
rename metrics function
alexander-alderman-webb dc6df68
Merge branch 'webb/dotnet-metrics' into webb/dotnet-metrics-page
alexander-alderman-webb c8a37fc
Merge branch 'webb/dotnet-metrics' into webb/dotnet-metrics-page
alexander-alderman-webb 7396c17
fix(getting-started): Xamarin does not supported Trace-connected Metrics
Flash0ver aadce21
Merge branch 'webb/dotnet-metrics' into webb/dotnet-metrics-page
Flash0ver 890b102
merge
Flash0ver 76bd03e
cleanup after merge
Flash0ver e4a9bf8
test: fix missing rename after merge
Flash0ver 435f4d5
update metrics test
alexander-alderman-webb 9eb6bd2
remove async from arrow function in test
alexander-alderman-webb b4fc71e
another instance
alexander-alderman-webb 1e32ef6
Merge branch 'webb/dotnet-metrics' into webb/dotnet-metrics-page
Flash0ver 5674735
fix: language identifier for C# code snippet
Flash0ver 0738f9d
fix: invalid syntax in C# code snippet
Flash0ver fb8d186
merge
alexander-alderman-webb ad8d666
Merge branch 'webb/dotnet-metrics' into webb/dotnet-metrics-page
Flash0ver 9a10bf2
ref: simplify .NET SDK version selector for getting started snippets
Flash0ver File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import {renderWithOnboardingLayout} from 'sentry-test/onboarding/renderWithOnboardingLayout'; | ||
| import {screen} from 'sentry-test/reactTestingLibrary'; | ||
| import {textWithMarkupMatcher} from 'sentry-test/utils'; | ||
|
|
||
| import {ProductSolution} from 'sentry/components/onboarding/gettingStartedDoc/types'; | ||
|
|
||
| import docs from '.'; | ||
|
|
||
| describe('metrics', () => { | ||
| it('dotnet metrics onboarding docs', () => { | ||
| renderWithOnboardingLayout(docs, { | ||
| selectedProducts: [ProductSolution.METRICS], | ||
| }); | ||
|
|
||
| expect( | ||
| screen.getByText( | ||
| textWithMarkupMatcher(/SentrySdk\.Experimental\.Metrics\.EmitCounter/) | ||
| ) | ||
| ).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('does not render metrics configuration when metrics is not enabled', () => { | ||
| renderWithOnboardingLayout(docs, { | ||
| selectedProducts: [], | ||
| }); | ||
|
|
||
| expect( | ||
| screen.queryByText( | ||
| textWithMarkupMatcher(/SentrySdk\.Experimental\.Metrics\.EmitCounter/) | ||
| ) | ||
| ).not.toBeInTheDocument(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,10 @@ | ||
| import type {DocsParams} from 'sentry/components/onboarding/gettingStartedDoc/types'; | ||
| import {getPackageVersion} from 'sentry/utils/gettingStartedDocs/getPackageVersion'; | ||
|
|
||
| // Sentry SDK for .NET 6.1.0 adds initial experimental support for Metrics | ||
| export const getInstallSnippetPackageManager = (params: DocsParams) => ` | ||
| Install-Package Sentry -Version ${getPackageVersion(params, 'sentry.dotnet', '6.0.0')}`; | ||
| Install-Package Sentry -Version ${getPackageVersion(params, 'sentry.dotnet', '6.1.0')}`; | ||
|
|
||
| // Sentry SDK for .NET 6.1.0 adds initial experimental support for Metrics | ||
| export const getInstallSnippetCoreCli = (params: DocsParams) => ` | ||
| dotnet add package Sentry -v ${getPackageVersion(params, 'sentry.dotnet', '6.0.0')}`; | ||
| dotnet add package Sentry -v ${getPackageVersion(params, 'sentry.dotnet', '6.1.0')}`; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.