Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"dependencies": {
"react": "^18",
"react-dom": "^18",
"next": "14.2.35"
"next": "16.1.5"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The nextjs-14-test-app is incorrectly upgraded to Next.js 16, breaking its dedicated tests and removing version-specific test coverage.
Severity: CRITICAL

Suggested Fix

Revert the dependency update in e2e-tests/test-applications/nextjs-14-test-app/package.json. The next package in this test application should remain on a Next.js 14.x version to maintain correct test coverage.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: e2e-tests/test-applications/nextjs-14-test-app/package.json#L14

Potential issue: The pull request updates the `next` dependency in
`nextjs-14-test-app/package.json` from version 14.x to 16.1.5. This change is incorrect
as this test application is specifically designed to validate integration with Next.js
14. A separate application, `nextjs-16-test-app`, already exists for testing Next.js 16.
This update will cause the `nextjs-14.test.ts` E2E test to fail due to structural
differences between Next.js 14 (which expects `src/app/layout.tsx`) and Next.js 16
(which uses `app/layout.tsx`). Consequently, this change eliminates test coverage for
Next.js 14.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next.js 14 test app upgraded to incompatible version 16

High Severity

The nextjs-14-test-app is a version-specific test application designed to verify Sentry wizard integration with Next.js 14. This Dependabot PR upgrades next from 14.2.35 to 16.1.5, which defeats the purpose of this test app since there's already a separate nextjs-16-test-app for testing Next.js 16. The associated test file nextjs-14.test.ts will no longer be testing Next.js 14 behavior, leaving that version untested.

Fix in Cursor Fix in Web

},
"devDependencies": {
"typescript": "^5",
Expand Down
Loading