Skip to content

test: Fix flaky transport specs with timecop #2978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sl0thentr0py merged 1 commit into from
Jun 18, 2026
+34 −28
Merged

test: Fix flaky transport specs with timecop #2978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 34 additions & 28 deletions sentry-ruby/spec/sentry/transport_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,24 +34,28 @@
let(:envelope) { subject.envelope_from_event(event) }

it "generates correct envelope content" do
result, _ = subject.serialize_envelope(envelope)
result = nil

envelope_header, item_header, item = result.split("\n")
envelope_header_parsed = JSON.parse(envelope_header)
Timecop.freeze do |frozen_time|
result, _ = subject.serialize_envelope(envelope)

expect(envelope_header_parsed).to eq({
"event_id" => event.event_id,
"dsn" => Sentry::TestHelper::DUMMY_DSN,
"sdk" => Sentry.sdk_meta,
"sent_at" => Time.now.utc.iso8601,
"trace" => dynamic_sampling_context
})
envelope_header, item_header, item = result.split("\n")
Comment thread
sl0thentr0py marked this conversation as resolved.
envelope_header_parsed = JSON.parse(envelope_header)

expect(item_header).to eq(
'{"type":"event","content_type":"application/json"}'
)
expect(envelope_header_parsed).to eq({
"event_id" => event.event_id,
"dsn" => Sentry::TestHelper::DUMMY_DSN,
"sdk" => Sentry.sdk_meta,
"sent_at" => frozen_time.utc.iso8601,
"trace" => dynamic_sampling_context
})

expect(item_header).to eq(
'{"type":"event","content_type":"application/json"}'
)

expect(item).to eq(event.to_h.to_json)
expect(item).to eq(event.to_h.to_json)
end
end
end

Expand All @@ -69,24 +73,26 @@
let(:envelope) { subject.envelope_from_event(event) }

it "generates correct envelope content" do
result, _ = subject.serialize_envelope(envelope)
Timecop.freeze do |frozen_time|
result, _ = subject.serialize_envelope(envelope)

envelope_header, item_header, item = result.split("\n")
envelope_header_parsed = JSON.parse(envelope_header)
envelope_header, item_header, item = result.split("\n")
envelope_header_parsed = JSON.parse(envelope_header)

expect(envelope_header_parsed).to eq({
"event_id" => event.event_id,
"dsn" => Sentry::TestHelper::DUMMY_DSN,
"sdk" => Sentry.sdk_meta,
"sent_at" => Time.now.utc.iso8601,
"trace" => dynamic_sampling_context
})
expect(envelope_header_parsed).to eq({
"event_id" => event.event_id,
"dsn" => Sentry::TestHelper::DUMMY_DSN,
"sdk" => Sentry.sdk_meta,
"sent_at" => frozen_time.utc.iso8601,
"trace" => dynamic_sampling_context
})

expect(item_header).to eq(
'{"type":"transaction","content_type":"application/json"}'
)
expect(item_header).to eq(
'{"type":"transaction","content_type":"application/json"}'
)

expect(item).to eq(event.to_h.to_json)
expect(item).to eq(event.to_h.to_json)
end
end

context "with profiling on transaction" do
Expand Down
Loading