-
-
Notifications
You must be signed in to change notification settings - Fork 355
DO NOT MERGE: e2e tests on Cirrus Labs runners #5485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- e2e tests on Cirrus Labs runners ([#5485](https://github.com/getsentry/sentry-react-native/pull/5485))If none of the above apply, you can opt out of this check by adding |
| platform: ["ios", "android"] | ||
| include: | ||
| - platform: ios | ||
| runs-on: macos-26 | ||
| runs-on: ["ghcr.io/cirruslabs/macos-tahoe-xcode:26.2", "runner_group_id:12"] | ||
| name: iOS | ||
| appPlain: performance-tests/test-app-plain.ipa | ||
| - platform: android | ||
| # Not using the latest version due to a known issue: https://github.com/getsentry/sentry-react-native/issues/4418 | ||
| runs-on: ubuntu-22.04 | ||
| runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:22.04", "runner_group_id:12"] | ||
| name: Android | ||
| appPlain: performance-tests/TestAppPlain/android/app/build/outputs/apk/release/app-release.apk | ||
| steps: |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| platform: ["ios", "android"] | ||
| include: | ||
| - platform: ios | ||
| runs-on: macos-26 | ||
| runs-on: ["ghcr.io/cirruslabs/macos-tahoe-xcode:26.2", "runner_group_id:12"] | ||
| name: iOS | ||
| appPlain: performance-tests/test-app-plain.ipa | ||
| - platform: android | ||
| # Not using the latest version due to a known issue: https://github.com/getsentry/sentry-react-native/issues/4418 | ||
| runs-on: ubuntu-22.04 | ||
| runs-on: ["ghcr.io/cirruslabs/ubuntu-runner-amd64:22.04", "runner_group_id:12"] | ||
| name: Android | ||
| appPlain: performance-tests/TestAppPlain/android/app/build/outputs/apk/release/app-release.apk | ||
| steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The runs-on array syntax ["image", "runner_group_id:12"] is invalid. GitHub Actions will wait indefinitely for a runner with both labels, which will never exist, causing jobs to hang.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The workflow jobs metrics, react-native-build, and react-native-test use an invalid array syntax for the runs-on key, such as ["ghcr.io/cirruslabs/macos-tahoe-xcode:26.2", "runner_group_id:12"]. GitHub Actions interprets this as requiring a runner that has both labels. However, runner_group_id:12 is not a valid label for Cirrus Runners. As a result, no runner will ever match the criteria, causing the jobs to hang indefinitely and eventually time out, blocking the CI/CD pipeline.
💡 Suggested Fix
Remove the invalid runner_group_id:12 element from the runs-on array. The correct configuration should only specify the container image, like runs-on: "ghcr.io/cirruslabs/macos-tahoe-xcode:26.2". This should be applied to all affected jobs.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/e2e-v2.yml#L47-L57
Potential issue: The workflow jobs `metrics`, `react-native-build`, and
`react-native-test` use an invalid array syntax for the `runs-on` key, such as
`["ghcr.io/cirruslabs/macos-tahoe-xcode:26.2", "runner_group_id:12"]`. GitHub Actions
interprets this as requiring a runner that has both labels. However,
`runner_group_id:12` is not a valid label for Cirrus Runners. As a result, no runner
will ever match the criteria, causing the jobs to hang indefinitely and eventually time
out, blocking the CI/CD pipeline.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7703441
📢 Type of change
📜 Description
Enabled Cirrus Labs runners for e2e tests. Fixes #5418
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps