Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Nov 11, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Breaking changes:

SubPRs:

💡 Motivation and Context

See #5273

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@antonis
Copy link
Contributor Author

antonis commented Nov 11, 2025

Marking as Blocked while the Cocoa v9 is in Alpha

itaybre and others added 3 commits November 11, 2025 16:38
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

---------

Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

---------

Co-authored-by: Itay Brenner <itay.brenner@sentry.io>
Co-authored-by: Itay Brenner <itaybrenner@hotmail.com>
Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

---------

Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>
Co-authored-by: Denis Andrasec <denrase@gmail.com>
Co-authored-by: Noah Martin <noahm444@gmail.com>
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Nov 11, 2025
@antonis
Copy link
Contributor Author

antonis commented Nov 11, 2025

Adding the ready-to-merge label to trigger all tests but it's not really ready to merge 😅

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 369.06 ms 386.56 ms 17.50 ms
Size 43.94 MiB 48.91 MiB 4.97 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ad27f6e+dirty 484.67 ms 532.79 ms 48.12 ms
f081f58+dirty 468.47 ms 492.64 ms 24.17 ms
294387d+dirty 359.44 ms 393.40 ms 33.97 ms
c08359e+dirty 406.04 ms 428.87 ms 22.83 ms
e07935d+dirty 380.10 ms 377.48 ms -2.62 ms
9b50d32+dirty 429.59 ms 423.89 ms -5.70 ms
3099014+dirty 344.58 ms 404.21 ms 59.63 ms
eec00c2+dirty 367.00 ms 392.12 ms 25.12 ms
a31630c+dirty 359.89 ms 416.90 ms 57.00 ms
e335046+dirty 375.75 ms 392.85 ms 17.10 ms

App size

Revision Plain With Sentry Diff
ad27f6e+dirty 43.94 MiB 48.90 MiB 4.96 MiB
f081f58+dirty 43.94 MiB 48.82 MiB 4.88 MiB
294387d+dirty 43.94 MiB 48.87 MiB 4.93 MiB
c08359e+dirty 7.15 MiB 8.42 MiB 1.27 MiB
e07935d+dirty 43.94 MiB 48.82 MiB 4.88 MiB
9b50d32+dirty 43.94 MiB 48.87 MiB 4.93 MiB
3099014+dirty 7.15 MiB 8.43 MiB 1.27 MiB
eec00c2+dirty 43.94 MiB 48.87 MiB 4.93 MiB
a31630c+dirty 7.15 MiB 8.41 MiB 1.26 MiB
e335046+dirty 43.94 MiB 48.87 MiB 4.93 MiB

Previous results on branch: cocoa-v9

Startup times

Revision Plain With Sentry Diff
0816bdc+dirty 576.86 ms 619.67 ms 42.81 ms
326e1a7+dirty 425.27 ms 425.81 ms 0.54 ms
9aa9f9b+dirty 597.51 ms 634.22 ms 36.71 ms

App size

Revision Plain With Sentry Diff
0816bdc+dirty 43.94 MiB 48.90 MiB 4.96 MiB
326e1a7+dirty 43.94 MiB 48.90 MiB 4.96 MiB
9aa9f9b+dirty 43.94 MiB 48.90 MiB 4.96 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 405.30 ms 422.77 ms 17.46 ms
Size 43.75 MiB 48.08 MiB 4.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
083f560+dirty 358.21 ms 382.00 ms 23.79 ms
ad27f6e+dirty 471.44 ms 516.23 ms 44.79 ms
f081f58+dirty 443.98 ms 480.26 ms 36.28 ms
d916aa3 425.37 ms 427.02 ms 1.65 ms
294387d+dirty 424.30 ms 465.40 ms 41.10 ms
90afdd3+dirty 375.94 ms 377.52 ms 1.58 ms
e07935d+dirty 448.82 ms 489.10 ms 40.29 ms
9b50d32+dirty 455.51 ms 466.56 ms 11.05 ms
eec00c2+dirty 447.08 ms 469.04 ms 21.96 ms
46bd012 387.09 ms 404.47 ms 17.38 ms

App size

Revision Plain With Sentry Diff
083f560+dirty 17.75 MiB 19.70 MiB 1.96 MiB
ad27f6e+dirty 43.75 MiB 48.07 MiB 4.32 MiB
f081f58+dirty 43.75 MiB 47.99 MiB 4.24 MiB
d916aa3 17.75 MiB 20.15 MiB 2.41 MiB
294387d+dirty 43.75 MiB 48.04 MiB 4.29 MiB
90afdd3+dirty 17.75 MiB 19.70 MiB 1.95 MiB
e07935d+dirty 43.75 MiB 47.99 MiB 4.24 MiB
9b50d32+dirty 43.75 MiB 48.04 MiB 4.29 MiB
eec00c2+dirty 43.75 MiB 48.05 MiB 4.29 MiB
46bd012 17.75 MiB 20.15 MiB 2.41 MiB

Previous results on branch: cocoa-v9

Startup times

Revision Plain With Sentry Diff
0816bdc+dirty 420.64 ms 447.37 ms 26.73 ms
326e1a7+dirty 426.45 ms 457.84 ms 31.39 ms
9aa9f9b+dirty 464.02 ms 490.62 ms 26.60 ms

App size

Revision Plain With Sentry Diff
0816bdc+dirty 43.75 MiB 48.07 MiB 4.32 MiB
326e1a7+dirty 43.75 MiB 48.07 MiB 4.32 MiB
9aa9f9b+dirty 43.75 MiB 48.07 MiB 4.32 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.00 ms 1217.90 ms -2.10 ms
Size 3.44 MiB 4.74 MiB 1.31 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
000da7a+dirty 1204.50 ms 1218.94 ms 14.44 ms
d1bfbde+dirty 1221.30 ms 1218.70 ms -2.60 ms
59f3a84+dirty 1205.09 ms 1213.31 ms 8.23 ms
5691430+dirty 1191.06 ms 1189.13 ms -1.94 ms
c4e097a+dirty 1231.35 ms 1246.91 ms 15.56 ms
652f785+dirty 1216.42 ms 1212.21 ms -4.21 ms
88890fe+dirty 1219.00 ms 1222.08 ms 3.08 ms
f081f58+dirty 1208.37 ms 1215.56 ms 7.19 ms
276d348+dirty 1222.10 ms 1229.02 ms 6.92 ms
ee69ed5+dirty 1212.78 ms 1214.91 ms 2.13 ms

App size

Revision Plain With Sentry Diff
000da7a+dirty 3.19 MiB 4.48 MiB 1.29 MiB
d1bfbde+dirty 3.41 MiB 4.58 MiB 1.17 MiB
59f3a84+dirty 3.19 MiB 4.56 MiB 1.37 MiB
5691430+dirty 3.41 MiB 4.59 MiB 1.18 MiB
c4e097a+dirty 3.19 MiB 4.44 MiB 1.25 MiB
652f785+dirty 3.41 MiB 4.57 MiB 1.16 MiB
88890fe+dirty 3.19 MiB 4.57 MiB 1.38 MiB
f081f58+dirty 3.41 MiB 4.58 MiB 1.17 MiB
276d348+dirty 3.19 MiB 4.54 MiB 1.36 MiB
ee69ed5+dirty 3.41 MiB 4.59 MiB 1.18 MiB

Previous results on branch: cocoa-v9

Startup times

Revision Plain With Sentry Diff
9aa9f9b+dirty 1217.00 ms 1212.65 ms -4.35 ms
0816bdc+dirty 1207.15 ms 1214.24 ms 7.10 ms
326e1a7+dirty 1188.46 ms 1201.64 ms 13.18 ms

App size

Revision Plain With Sentry Diff
9aa9f9b+dirty 3.41 MiB 4.74 MiB 1.33 MiB
0816bdc+dirty 3.44 MiB 4.74 MiB 1.30 MiB
326e1a7+dirty 3.41 MiB 4.74 MiB 1.33 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1188.04 ms 1198.19 ms 10.15 ms
Size 3.44 MiB 4.74 MiB 1.31 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
000da7a+dirty 1214.31 ms 1221.91 ms 7.61 ms
d1bfbde+dirty 1216.83 ms 1212.83 ms -3.99 ms
59f3a84+dirty 1232.56 ms 1238.12 ms 5.56 ms
5691430+dirty 1218.89 ms 1222.22 ms 3.33 ms
c4e097a+dirty 1229.09 ms 1242.61 ms 13.53 ms
652f785+dirty 1219.66 ms 1223.62 ms 3.96 ms
88890fe+dirty 1219.20 ms 1231.00 ms 11.80 ms
f081f58+dirty 1219.10 ms 1217.57 ms -1.53 ms
276d348+dirty 1224.22 ms 1227.38 ms 3.16 ms
ee69ed5+dirty 1206.79 ms 1213.98 ms 7.19 ms

App size

Revision Plain With Sentry Diff
000da7a+dirty 2.63 MiB 3.91 MiB 1.28 MiB
d1bfbde+dirty 3.41 MiB 4.58 MiB 1.17 MiB
59f3a84+dirty 2.63 MiB 3.99 MiB 1.36 MiB
5691430+dirty 3.41 MiB 4.59 MiB 1.18 MiB
c4e097a+dirty 2.63 MiB 3.87 MiB 1.24 MiB
652f785+dirty 3.41 MiB 4.57 MiB 1.16 MiB
88890fe+dirty 2.63 MiB 4.00 MiB 1.37 MiB
f081f58+dirty 3.41 MiB 4.58 MiB 1.17 MiB
276d348+dirty 2.63 MiB 3.98 MiB 1.34 MiB
ee69ed5+dirty 3.41 MiB 4.59 MiB 1.18 MiB

Previous results on branch: cocoa-v9

Startup times

Revision Plain With Sentry Diff
9aa9f9b+dirty 1216.96 ms 1214.32 ms -2.64 ms
0816bdc+dirty 1223.46 ms 1221.28 ms -2.18 ms
326e1a7+dirty 1210.09 ms 1217.29 ms 7.20 ms

App size

Revision Plain With Sentry Diff
9aa9f9b+dirty 3.41 MiB 4.74 MiB 1.33 MiB
0816bdc+dirty 3.44 MiB 4.74 MiB 1.30 MiB
326e1a7+dirty 3.41 MiB 4.74 MiB 1.33 MiB

@antonis antonis changed the title chore(deps): update Cocoa SDK to v9.0.0-alpha.0 chore(deps): update Cocoa SDK to v9.0.0-alpha Nov 13, 2025
@antonis
Copy link
Contributor Author

antonis commented Nov 13, 2025

fix(podspec): Cocoa V9 allow any alpha version

Thank you @philipphofmann 🦸

antonis and others added 2 commits November 13, 2025 12:00
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

* chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9

---------

Co-authored-by: Itay Brenner <itay.brenner@sentry.io>
Co-authored-by: Itay Brenner <itaybrenner@hotmail.com>
Co-authored-by: Denis Andrasec <denrase@gmail.com>
Co-authored-by: Noah Martin <noahm444@gmail.com>
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

* chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9

* chore(e2e): Cocoa-v9: Bump E2E to iOS 15.0

* Bump to 15.1 due to RN 0.81.0 requirements

---------

Co-authored-by: Itay Brenner <itay.brenner@sentry.io>
Co-authored-by: Itay Brenner <itaybrenner@hotmail.com>
Co-authored-by: Denis Andrasec <denrase@gmail.com>
Co-authored-by: Noah Martin <noahm444@gmail.com>
@antonis antonis removed the ready-to-merge Triggers the full CI test suite label Nov 13, 2025
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Nov 13, 2025
@antonis antonis changed the title chore(deps): update Cocoa SDK to v9.0.0-rc chore(deps): update Cocoa SDK to v9.0.0 GA Dec 1, 2025
@lucas-zimerman
Copy link
Collaborator

V9 was released so I will unblock this issue

@antonis
Copy link
Contributor Author

antonis commented Dec 3, 2025

V9 was released so I will unblock this issue

Correct. I'll keep it in draft for now since we are not going to merge on the main branch but on v8.

I've also opened getsentry/sentry-cocoa#6942 that I hope is going to fix some of the issues

@antonis antonis changed the title chore(deps): update Cocoa SDK to v9.0.0 GA chore(deps): update Cocoa SDK to v9 Dec 11, 2025
@antonis antonis removed the ready-to-merge Triggers the full CI test suite label Dec 11, 2025
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Dec 11, 2025
@antonis
Copy link
Contributor Author

antonis commented Dec 11, 2025

The CI is 🟢 again with 9.1.0 and the current issues are solved. The sample app also behaved as expected in my manual tests 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants