Skip to content

ref: Rename _get_current_streamed_span#6490

Merged
sentrivana merged 2 commits into
masterfrom
ivana/get-current-streamed-span
Jun 3, 2026
Merged

ref: Rename _get_current_streamed_span#6490
sentrivana merged 2 commits into
masterfrom
ivana/get-current-streamed-span

Conversation

@sentrivana

@sentrivana sentrivana commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Description

Follow the existing convention of defining the future top-level API functions in traces.py under their future names

Issues

Reminders

Comment thread sentry_sdk/api.py
from sentry_sdk.scope import Scope, _ScopeManager, isolation_scope, new_scope
from sentry_sdk.traces import StreamedSpan, _get_current_streamed_span
from sentry_sdk.traces import StreamedSpan
from sentry_sdk.traces import get_current_span as _get_current_streamed_span

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is aliased to an underscore func on purpose since we don't want to advertise it as importable from the top level api

@sentrivana sentrivana marked this pull request as ready for review June 3, 2026 09:26
@sentrivana sentrivana requested a review from a team as a code owner June 3, 2026 09:26
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

88644 passed | ⏭️ 6022 skipped | Total: 94666 | Pass Rate: 93.64% | Execution Time: 289m 51s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +194
Passed Tests 📈 +192
Failed Tests
Skipped Tests 📈 +2

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2468 uncovered lines.
✅ Project coverage is 89.39%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/celery/init.py 100.00% ⚠️ 1 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.39%    89.39%        —%
==========================================
  Files          192       192         —
  Lines        23264     23265        +1
  Branches      7996      7996         —
==========================================
+ Hits         20796     20797        +1
- Misses        2468      2468         —
- Partials      1308      1308         —

Generated by Codecov Action

@sentrivana sentrivana merged commit 610f7b7 into master Jun 3, 2026
395 of 400 checks passed
@sentrivana sentrivana deleted the ivana/get-current-streamed-span branch June 3, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants