Skip to content

fix(langchain): add gen_ai.response.model to chat spans#5159

Merged
shellmayr merged 4 commits into
masterfrom
shellmayr/fix/add-gen-ai-response-model-langchain
Nov 28, 2025
Merged

fix(langchain): add gen_ai.response.model to chat spans#5159
shellmayr merged 4 commits into
masterfrom
shellmayr/fix/add-gen-ai-response-model-langchain

Conversation

@shellmayr

@shellmayr shellmayr commented Nov 27, 2025

Copy link
Copy Markdown
Member
  • Retrieve the response model from generation.message.response_metadata instead of generation.generation_info

Closes TET-1455

@linear

linear Bot commented Nov 27, 2025

Copy link
Copy Markdown

@shellmayr shellmayr marked this pull request as ready for review November 27, 2025 14:59
@shellmayr shellmayr requested a review from a team as a code owner November 27, 2025 14:59
Comment thread sentry_sdk/integrations/langchain.py Outdated
@codecov

codecov Bot commented Nov 27, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.94%. Comparing base (ab0103e) to head (d533268).
⚠️ Report is 11 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5159      +/-   ##
==========================================
- Coverage   83.98%   83.94%   -0.04%     
==========================================
  Files         180      181       +1     
  Lines       18227    18335     +108     
  Branches     3236     3259      +23     
==========================================
+ Hits        15308    15392      +84     
- Misses       1929     1938       +9     
- Partials      990     1005      +15     
Files with missing lines Coverage Δ
sentry_sdk/integrations/langchain.py 71.85% <100.00%> (+0.34%) ⬆️

... and 13 files with indirect coverage changes

@shellmayr shellmayr merged commit 176c7d4 into master Nov 28, 2025
157 checks passed
@shellmayr shellmayr deleted the shellmayr/fix/add-gen-ai-response-model-langchain branch November 28, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants