Skip to content

ref: Remove datetime_from_isoformat#5043

Closed
sentrivana wants to merge 1 commit into
major/3.0from
ivana/3.0/remove-datetime-from-iso
Closed

ref: Remove datetime_from_isoformat#5043
sentrivana wants to merge 1 commit into
major/3.0from
ivana/3.0/remove-datetime-from-iso

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

Description

The only purpose of this util function was compatibility with Python 3.6.

Issues

Closes #5009

Reminders

@codecov

codecov Bot commented Oct 29, 2025

Copy link
Copy Markdown

❌ 12 Tests Failed:

Tests completed Failed Passed Skipped
24213 12 24201 1709
View the top 3 failed test(s) by shortest run time
tests.test_basics::test_breadcrumb_ordering
Stack Traces | 0.072s run time
tests/test_basics.py:426: in test_breadcrumb_ordering
    for x in event["breadcrumbs"]["values"]
tests/test_basics.py:426: in <listcomp>
    for x in event["breadcrumbs"]["values"]
E   ValueError: Invalid isoformat string: '2025-10-17T16:21:29.000000Z'
tests.test_basics::test_breadcrumb_ordering_different_types
Stack Traces | 0.072s run time
tests/test_basics.py:470: in test_breadcrumb_ordering_different_types
    for x in event["breadcrumbs"]["values"]
tests/test_basics.py:470: in <listcomp>
    for x in event["breadcrumbs"]["values"]
E   ValueError: Invalid isoformat string: '2025-10-19T16:21:29.370377Z'
tests.test_basics::test_breadcrumb_ordering
Stack Traces | 0.083s run time
tests/test_basics.py:422: in test_breadcrumb_ordering
    timestamps_from_event = [
tests/test_basics.py:423: in <listcomp>
    datetime.datetime.fromisoformat(x["timestamp"]).astimezone(
E   ValueError: Invalid isoformat string: '2025-10-17T16:21:21.000000Z'
tests.test_basics::test_breadcrumb_ordering_different_types
Stack Traces | 0.083s run time
tests/test_basics.py:466: in test_breadcrumb_ordering_different_types
    timestamps_from_event = [
tests/test_basics.py:467: in <listcomp>
    datetime.datetime.fromisoformat(x["timestamp"]).astimezone(
E   ValueError: Invalid isoformat string: '2025-10-19T16:21:22.092921Z'
tests.test_basics::test_breadcrumb_ordering
Stack Traces | 0.084s run time
tests/test_basics.py:422: in test_breadcrumb_ordering
    timestamps_from_event = [
tests/test_basics.py:423: in <listcomp>
    datetime.datetime.fromisoformat(x["timestamp"]).astimezone(
E   ValueError: Invalid isoformat string: '2025-10-17T16:22:07.000000Z'
tests.test_basics::test_breadcrumb_ordering_different_types
Stack Traces | 0.084s run time
tests/test_basics.py:466: in test_breadcrumb_ordering_different_types
    timestamps_from_event = [
tests/test_basics.py:467: in <listcomp>
    datetime.datetime.fromisoformat(x["timestamp"]).astimezone(
E   ValueError: Invalid isoformat string: '2025-10-19T16:22:07.175650Z'
tests.test_basics::test_breadcrumb_ordering_different_types
Stack Traces | 0.092s run time
tests/test_basics.py:466: in test_breadcrumb_ordering_different_types
    timestamps_from_event = [
tests/test_basics.py:467: in <listcomp>
    datetime.datetime.fromisoformat(x["timestamp"]).astimezone(
E   ValueError: Invalid isoformat string: '2025-10-19T16:22:23.511920Z'
tests.test_basics::test_breadcrumb_ordering
Stack Traces | 0.094s run time
tests/test_basics.py:422: in test_breadcrumb_ordering
    timestamps_from_event = [
tests/test_basics.py:423: in <listcomp>
    datetime.datetime.fromisoformat(x["timestamp"]).astimezone(
E   ValueError: Invalid isoformat string: '2025-10-17T16:21:22.000000Z'
tests.test_basics::test_breadcrumb_ordering
Stack Traces | 0.094s run time
tests/test_basics.py:422: in test_breadcrumb_ordering
    timestamps_from_event = [
tests/test_basics.py:423: in <listcomp>
    datetime.datetime.fromisoformat(x["timestamp"]).astimezone(
E   ValueError: Invalid isoformat string: '2025-10-17T16:22:22.000000Z'
tests.test_basics::test_breadcrumb_ordering
Stack Traces | 0.094s run time
tests/test_basics.py:422: in test_breadcrumb_ordering
    timestamps_from_event = [
tests/test_basics.py:423: in <listcomp>
    datetime.datetime.fromisoformat(x["timestamp"]).astimezone(
E   ValueError: Invalid isoformat string: '2025-10-17T16:22:23.000000Z'
tests.test_basics::test_breadcrumb_ordering_different_types
Stack Traces | 0.094s run time
tests/test_basics.py:466: in test_breadcrumb_ordering_different_types
    timestamps_from_event = [
tests/test_basics.py:467: in <listcomp>
    datetime.datetime.fromisoformat(x["timestamp"]).astimezone(
E   ValueError: Invalid isoformat string: '2025-10-19T16:21:22.537286Z'
tests.test_basics::test_breadcrumb_ordering_different_types
Stack Traces | 0.094s run time
tests/test_basics.py:466: in test_breadcrumb_ordering_different_types
    timestamps_from_event = [
tests/test_basics.py:467: in <listcomp>
    datetime.datetime.fromisoformat(x["timestamp"]).astimezone(
E   ValueError: Invalid isoformat string: '2025-10-19T16:22:22.811694Z'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sentrivana sentrivana closed this Oct 31, 2025
@sentrivana sentrivana deleted the ivana/3.0/remove-datetime-from-iso branch December 10, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant