Merge master#2112
Open
Litarnus wants to merge 99 commits into
Open
Conversation
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#2028) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…2c5970a8098588e2eaecd to 43bf14b190c12080cfbedf2d2c82337bc559a0e1 (#2081) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…edf2d2c82337bc559a0e1 to 24be69680c3a46c03edfbeb05268ec312f77e1e7 (#2088) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….yml from 2.26.2 to 2.26.3 (#2087) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…fbeb05268ec312f77e1e7 to c802283cd9075b7a2b7a32655019c21c21676e34 (#2097) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#2089) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….yml from 2.26.3 to 2.26.6 (#2096) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
# Conflicts: # .github/workflows/ci.yml # .github/workflows/publish-release.yaml # CHANGELOG.md # composer.json # phpstan-baseline.neon # psalm.xml.dist # src/Client.php # src/Event.php # src/Integration/ModulesIntegration.php # src/Integration/RequestIntegration.php # src/Logs/LogsAggregator.php # src/Options.php # src/SentrySdk.php # src/State/RuntimeContextManager.php # src/Tracing/DynamicSamplingContext.php # src/Tracing/Traits/TraceHeaderParserTrait.php # src/functions.php # tests/ClientReport/ClientReportAggregatorTest.php # tests/Logs/LogsAggregatorTest.php # tests/Metrics/TraceMetricsTest.php # tests/Monolog/LogsHandlerTest.php # tests/OptionsTest.php # tests/SentrySdkExtension.php # tests/SentrySdkTest.php # tests/Serializer/PayloadSerializerTest.php # tests/State/ScopeTest.php # tests/Tracing/StrictTraceContinuationTest.php
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 82f5840. Configure here.
|
|
||
| if ($profilesSampleRate === null) { | ||
| $logger->info(\sprintf('Transaction [%s] is not profiling because `profiles_sample_rate` option is not set.', (string) $transaction->getTraceId())); | ||
| $logger->info(\sprintf('Transaction [%s] is not profiling because neither `profiles_sample_rate` nor `profiles_sampler` option is set.', (string) $transaction->getTraceId())); |
There was a problem hiding this comment.
Wrong profile skip log message
Low Severity
When profiles_sampler is configured but its callback returns null, profiling is skipped via the profilesSampleRate === null branch, which logs that neither profiles_sample_rate nor profiles_sampler is set. That message is incorrect and differs from trace sampling, which treats a null sampler result as an invalid rate.
Reviewed by Cursor Bugbot for commit 82f5840. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.