feat(transport): add HTTP retry with exponential backoff#1520

Open

jpnurmi wants to merge 103 commits intomasterfrom

jpnurmi/feat/http-retry

Commits on Mar 17, 2026

feat(transport): add HTTP retry logic with exponential backoff

jpnurmi
and
claude
committed
fix(retry): filter startup scan by timestamp, create cache dir

jpnurmi
and
claude
committed
fix(retry): use wall clock time instead of monotonic time

jpnurmi
and
claude
committed
ref(retry): define backoff base in seconds

jpnurmi
and
claude
committed
ref(retry): replace scan+free_paths with foreach callback API

jpnurmi
and
claude
committed
feat(transport): set 15s request timeout for curl and winhttp

jpnurmi
and
claude
committed
fix(retry): avoid duplicate delayed retry tasks on startup

jpnurmi
and
claude
committed
ref(retry): take options in sentry__retry_new, own path construction

jpnurmi
and
claude
committed
ref(retry): set startup_time at creation, remove setter

jpnurmi
and
claude
committed
fix(retry): return total file count so polling continues during backoff

jpnurmi
and
claude
committed
fix(retry): use callback return value to track remaining retry files

jpnurmi
and
claude
committed
ref(retry): rename constants to SENTRY_RETRY_INTERVAL and SENTRY_RETRY_THROTTLE

jpnurmi
and
claude
committed
ref(retry): encapsulate retry scheduling into the retry module

jpnurmi
and
claude
committed
ref(transport): remove unnecessary includes, restore blank line

jpnurmi
and
claude
committed
ref(retry): move precondition checks to callers

jpnurmi
and
claude
committed
ref(transport): extract http_send_envelope helper

jpnurmi
and
claude
committed
test(retry): remove redundant retry_no_duplicate_rescan test

jpnurmi
and
claude
committed
ref(curl): use CURLOPT_TIMEOUT_MS for consistency with winhttp and crashpad

jpnurmi
and
claude
committed
ref(retry): unify startup and poll into a single task

jpnurmi
and
claude
committed
ref(retry): extract sentry__retry_make_path helper

jpnurmi
and
claude
committed
fix(retry): prevent envelope duplication between retry and cache

jpnurmi
and
claude
committed
ref(database): derive can_cache flag to skip cache dir creation early

jpnurmi
and
claude
committed
ref(retry): change send callback to envelope-based API

jpnurmi
and
claude
committed
test(retry): verify cache_keep preserves envelopes on successful send

jpnurmi
and
claude
committed
fix(retry): use PRIu64 format specifier for uint64_t

jpnurmi
and
claude
committed
fix(retry): guard against unsigned underflow in backoff check

jpnurmi
and
claude
committed
fix(retry): prevent startup poll from re-processing same-session envelopes

jpnurmi
and
claude
committed
fix(retry): flush pending retries on shutdown

jpnurmi
and
claude
committed
ref(retry): use millisecond timestamps for retry filenames

jpnurmi
and
claude
committed
fix(retry): flush pending retries synchronously before shutdown

jpnurmi
and
claude
committed
fix(retry): stop retrying on network failure

jpnurmi
and
claude
committed
fix(retry): dump unsent envelopes to retry dir on shutdown timeout

jpnurmi
and
claude
committed
test(retry): update expectations for stop-on-failure behavior

jpnurmi
and
claude
committed
style(retry): fix line length in unit tests

jpnurmi
and
claude
committed
fix(retry): prevent duplicate envelope writes from detached worker

jpnurmi
and
claude
committed
docs: add changelog entry for HTTP retry feature

jpnurmi
and
claude
committed
test(retry): use sentry__retry_send instead of duplicated eligibility logic

jpnurmi
and
claude
committed
fix(retry): raise backoff cap from 2h to 8h to match crashpad

jpnurmi
and
claude
committed
refactor(retry): introduce retry_item_t to avoid re-parsing filenames

jpnurmi
and
claude
committed
feat(retry): add debug and warning output for HTTP retries

jpnurmi
and
claude
committed
refactor(cache): add cache_path to sentry_run_t and centralize cache writes

jpnurmi
and
claude
committed
fix(transport): use connect-only timeouts for curl and winhttp

jpnurmi
and
claude
committed
fix(retry): decrement total count when removing corrupt envelope files

jpnurmi
and
claude
committed
fix(retry): only warn about exhausted retries on network failure

jpnurmi
and
claude
committed
docs(retry): add doc comments to sentry_retry.h declarations

jpnurmi
and
claude
committed
feat(transport): add sentry_transport_retry()

jpnurmi
and
claude
committed
refactor(retry): store retry envelopes in cache/ directory

jpnurmi
and
claude
committed
fix(retry): own cache_path to prevent use-after-free on detached thread

jpnurmi
and
claude
committed
fix(retry): don't consume shutdown timeout with bgworker flush

jpnurmi
and
claude
committed
fix(retry): flush in-flight retries before shutdown

jpnurmi
and
claude
committed
refactor(retry): replace http_retries count with boolean http_retry

jpnurmi
and
claude
committed
fix(transport): use explicit WinHTTP send/receive timeouts

jpnurmi
and
claude
committed
fix(retry): deduplicate poll tasks on concurrent envelope failures

jpnurmi
and
claude
committed
fix(retry): set sealed flag before dumping queued envelopes

jpnurmi
and
claude
committed
fix(retry): prevent retry flush from consuming shutdown timeout

jpnurmi
and
claude
committed
fix(retry): zero-initialize retry struct after malloc

jpnurmi
and
claude
committed
fix(retry): skip flush task after seal to prevent duplicate sends

jpnurmi
and
claude
committed
refactor(database): remove unused sentry__run_write_cache

jpnurmi
and
claude
committed
fix(retry): make trigger one-shot to prevent rapid retry exhaustion

jpnurmi
and
claude
committed
fix(core): check http_retry option instead of transport capability

jpnurmi
and
claude
committed
fix(retry): prevent UB from negative count in backoff shift

jpnurmi
and
claude
committed
fix(options): normalize http_retry with !! to match other boolean setters

jpnurmi
and
claude
committed
revert(database): restore original variable names and whitespace in write_envelope

jpnurmi
and
claude
committed
docs: clarify sentry_transport_retry behavior and limitations
jpnurmi
committed
docs(retry): document retry behavior for network failures vs HTTP responses
jpnurmi
committed
fix(retry): only clear startup_time when envelope is written
jpnurmi
committed
fix(retry): check for NULL from sentry__path_clone
jpnurmi
committed
fix(retry): apply backoff when system clock moves backward
jpnurmi
committed
fix(retry): increase SENTRY_RETRY_ATTEMPTS to 6 to match Crashpad

jpnurmi
and
claude
committed
fix(retry): avoid retry flush consuming entire shutdown timeout

jpnurmi
and
claude
committed
fix(retry): warn on failed retry envelope rename

jpnurmi
and
claude
committed
fix(retry): check for NULL from sentry__path_clone in retry send

jpnurmi
and
claude
committed
fix(retry): fix data race on startup_time between threads

jpnurmi
and
claude
committed
fix(retry): clear retry_func when retry fails to initialize

jpnurmi
and
claude
committed
fix(retry): persist non-event envelopes to the retry cache

jpnurmi
and
claude
committed
fix(retry): close race between poll task and enqueue on scheduled flag

jpnurmi
and
claude
committed
refactor(database): add retry_count to write_envelope, add sentry__run_write_cache

jpnurmi
and
claude
committed
refactor(database): make sentry_run_t refcounted

jpnurmi
and
claude
committed
refactor(cache): strip retry prefix in move_cache and simplify handle_result

jpnurmi
and
claude
committed
fix(cache): use cache_name instead of src_name for UUID in move_cache

jpnurmi
and
claude
committed
fix(retry): prevent duplicate cache writes during shutdown race

jpnurmi
and
claude
committed
fix(cache): replace length heuristic with proper filename parsing in move_cache

jpnurmi
and
claude
committed
docs: fix retry count 5 → 6 in sentry_transport_retry docs

jpnurmi
and
claude
committed
fix(retry): prevent poll task from re-arming after shutdown

jpnurmi
and
claude
committed
fix(winhttp): cancel in-flight request before shutdown to unblock worker

jpnurmi
and
claude
committed
fix(winhttp): fix double-close race on client->request between cancel and worker

jpnurmi
and
claude
committed
fix(winhttp): use on_timeout callback to unblock worker instead of cancel

jpnurmi
and
claude
committed
fix(winhttp): remove unnecessary local request snapshot in winhttp_send_task

jpnurmi
and
claude
committed
fix(sync): don't force running=0 before on_timeout callback

jpnurmi
and
claude
committed
fix(test): disable transport retry in unit tests to fix valgrind flakiness

jpnurmi
and
claude
committed
fix(retry): clear sealed_envelope after match to prevent address-reuse data loss

jpnurmi
and
claude
committed
ref: consolidate filename formatting into make_cache_path

jpnurmi
and
claude
committed
Adapt to sentry__session_new() change
jpnurmi
committed
ref: cache envelopes only on failed HTTP send

jpnurmi
and
claude
committed
Clarify bgworker shutdown timeout comment

jpnurmi
and
claude
committed
Cache envelopes only on failed HTTP send

jpnurmi
and
claude
committed
Remove unused sentry__transport_can_retry

jpnurmi
and
claude
committed
fix: incref options in cleanup task to prevent use-after-free

jpnurmi
and
claude
committed
Update sentry docs URL for network failure handling
jpnurmi
committed
Replace pointer comparison with envelope tag in retry seal check

jpnurmi
and
claude
committed
Add TODO for retry jitter and shorter poll interval
jpnurmi
committed
Initialize tag for raw envelopes loaded from disk

cursoragent
authored and
jpnurmi
committed

Commits on Mar 18, 2026

Implement on_timeout for curl transport

jpnurmi
and
claude
committed

Uh oh!

Commits

Commits on Mar 17, 2026

Commits on Mar 18, 2026