Skip to content

fix: prevent double-decref of event in envelope add functions #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpnurmi merged 2 commits into from
Feb 11, 2026
Merged

fix: prevent double-decref of event in envelope add functions #1511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4301f2a
fix: prevent double-decref of event in envelope add functions
jpnurmi Feb 11, 2026
5c518e4
Update CHANGELOG.md
jpnurmi Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
**Fixes**:

- Remove spurious decref in `sentry_capture_user_feedback()` ([#1510](https://github.com/getsentry/sentry-native/pull/1510))
- Prevent double-decref of event in envelope add functions ([#1511](https://github.com/getsentry/sentry-native/pull/1511))

## 0.12.6

Expand Down
4 changes: 2 additions & 2 deletions src/sentry_envelope.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,12 +296,12 @@ sentry__envelope_add_event(sentry_envelope_t *envelope, sentry_value_t event)
sentry_uuid_t event_id;
sentry__ensure_event_id(event, &event_id);

item->event = event;
sentry__jsonwriter_write_value(jw, event);
item->payload = sentry__jsonwriter_into_string(jw, &item->payload_len);
if (!item->payload) {
return NULL;
}
item->event = event;

sentry__envelope_item_set_header(
item, "type", sentry_value_new_string("event"));
Expand Down Expand Up @@ -381,12 +381,12 @@ sentry__envelope_add_transaction(
sentry_uuid_t event_id;
sentry__ensure_event_id(transaction, &event_id);

item->event = transaction;
sentry__jsonwriter_write_value(jw, transaction);
item->payload = sentry__jsonwriter_into_string(jw, &item->payload_len);
if (!item->payload) {
return NULL;
}
item->event = transaction;

sentry__envelope_item_set_header(
item, "type", sentry_value_new_string("transaction"));
Expand Down
Loading