fix(node): Restore eslint-disable in vendored tedious instrumentation#21615
Closed
andreiborza wants to merge 1 commit into
Closed
fix(node): Restore eslint-disable in vendored tedious instrumentation#21615andreiborza wants to merge 1 commit into
andreiborza wants to merge 1 commit into
Conversation
The "Streamline tedious instrumentation" refactor (#21598) dropped the `/* eslint-disable */` directive from the vendored instrumentation file while keeping its imports of the deprecated semconv constants (`ATTR_DB_SYSTEM`, `ATTR_DB_NAME`, etc.). Without the directive, the `typescript-eslint(no-deprecated)` rule fires on every usage, breaking the Lint CI job. Restore the directive after the header block, matching the documented vendoring convention and every other vendored instrumentation file (mysql, knex, postgres, hapi, mongo). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
andreiborza
requested review from
JPeer264 and
mydea
and removed request for
a team
Member
Author
|
Duplicate of #21616 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Lint CI job (
typescript-eslint(no-deprecated)) has been failing ondevelopsince #21598. It was auto-filed as a flaky test, but the failure is deterministic.Root cause: The "Streamline tedious instrumentation" refactor (#21598) removed the
/* eslint-disable */directive frompackages/node/src/integrations/tracing/tedious/vendored/instrumentation.tswhile keeping its imports of the deprecated vendored semconv constants (ATTR_DB_SYSTEM,ATTR_DB_NAME,ATTR_DB_USER,ATTR_DB_STATEMENT,ATTR_DB_SQL_TABLE,ATTR_NET_PEER_NAME,ATTR_NET_PEER_PORT). Those constants carry@deprecatedJSDoc tags copied verbatim from upstream OpenTelemetry, so without the directive theno-deprecatedrule fires on every usage.This restores the directive after the header block, matching the documented vendoring convention and every other vendored instrumentation file (mysql, knex, postgres, hapi, mongo). The deliberate use of the legacy
db.*/net.*attribute names is unchanged.Fixes #21614