feat(node): Add v7 support for vercelAiIntegration#21613
Draft
mydea wants to merge 5 commits into
Draft
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 21822ce. Configure here.
| // `@sentry/opentelemetry/tracing-channel` as the factory so spans become the active OTel | ||
| // context via `bindStore` (giving correct parent/child nesting). That factory needs the Sentry | ||
| // OTel context manager, which `initOpenTelemetry()` registers after `setupOnce`, so defer a tick. | ||
| void Promise.resolve().then(() => subscribeVercelAiTracingChannel(otelTracingChannel)); |
There was a problem hiding this comment.
V7 never registers Vercel processors
High Severity
With ai v7, OTel instrumentation no longer patches the package, so callWhenPatched never runs. addVercelAiProcessors is only registered when shouldForce is true at afterAllSetup. If the Modules integration does not list ai then (typical for ESM before import or when ai is missing from cwd package.json dependencies), v7 channel spans are emitted but transaction processors never run—no tool descriptions, parent token rollup, or related enrichment.
Reviewed by Cursor Bugbot for commit 21822ce. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the latest beta release of v7 of the ai package, native tracing channel events are now emitted. This PR adds support for this and thus for instrumentation in this package.
For now, this is only implemented in node, but can also be ported to deno/bun.
A big part of this PR was making sure that the v6 tests also run for v7 to make sure this is compatible. It may need some cleanup but tests pass now.
Supersedes #21584