ref(node): Streamline hapi instrumentation#21602
Open
nicohrubec wants to merge 1 commit into
Open
Conversation
Move vendored hapi span creation onto Sentry's span API (startSpan), fold op/origin into creation, drop the spanStart hook + semconv-stability branching, and add unit tests plus plugin-route/server.ext integration coverage. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
nicohrubec
requested review from
JPeer264,
andreiborza,
logaretm and
mydea
and removed request for
a team
JPeer264
approved these changes
Jun 17, 2026
| import { Attributes } from '@opentelemetry/api'; | ||
| import { ATTR_HTTP_ROUTE, ATTR_HTTP_REQUEST_METHOD } from '@opentelemetry/semantic-conventions'; | ||
| import type { Attributes } from '@opentelemetry/api'; | ||
| import { ATTR_HTTP_ROUTE } from '@opentelemetry/semantic-conventions'; |
Member
There was a problem hiding this comment.
l: Should we already move this to the sentry conventions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlines the vendored
hapiinstrumentation to use Sentry's span APIs instead of the OpenTelemetry tracing APIs, and removes the code paths that are dead in Sentry's context. Removed the clientspanStarthook that was previously used to set the origin. The origin is now set directly when starting the span. Test suites expanded to cover all APIs we instrument.Closes #20729