ref(core/opentelemetry): Set low cardinality db span names when span streaming is enabled#21599
Draft
Lms24 wants to merge 2 commits into
Draft
ref(core/opentelemetry): Set low cardinality db span names when span streaming is enabled#21599Lms24 wants to merge 2 commits into
db span names when span streaming is enabled#21599Lms24 wants to merge 2 commits into
Conversation
…eaming is enabled
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
Lms24
changed the title
db span names when span streaming is enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds low cardinality span name construction to the database span name inferral logic our SDK applies to OTel-generated spans. This is likely something we can in the future pull into individual instrumentations but as long all spans go through
parseSpanDescriptionit's the easiest place to add the logic to.Concrete changes:
buildSpanNamehelper to core that takes string templates and a data object from which to find the first matching span name. This is heavily inspired by span name rules in Sentry conventions and the templates are an almost exact copy of the ones for db spans in conventions.buildSpanNameutility on db span inference logic IFF span streaming is enabled