test(node): Use random port in hono tracing scenario to avoid CI flakes#21536
Merged
Conversation
Fixes #21174 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the flaky
suites/tracing/hono/test.tsNode integration test (should handle transactions for all route/method/path combinations).Root cause
The Hono tracing scenario binds its server to a hardcoded port
8787:The integration-test runner explicitly warns against this — a fixed port is fine for local debugging but "dangerous for CI/CD environments where port collisions can cause flakes". When port
8787is already in use (e.g. a not-yet-fully-killed child process from a prior run, or another concurrent suite),@hono/node-serverfails to bind, the scenario never serves requests on a usable socket, and the runner times out waiting for transactions — surfacing as an intermittent failure.The sibling
suites/hono-sdk/scenario.mjsalready uses the correct pattern: bind to port0(OS-assigned free port) and report the actually-bound port back to the runner via theservecallback. This change mirrors that:Test behavior and assertions are unchanged — only the port allocation strategy is fixed, eliminating the collision window.
Fixes #21174