chore(deps-dev): bump @testing-library/react from 13.0.0 to 15.0.5#19194
Open
dependabot[bot] wants to merge 1 commit intodevelopfrom
Open
chore(deps-dev): bump @testing-library/react from 13.0.0 to 15.0.5#19194dependabot[bot] wants to merge 1 commit intodevelopfrom
dependabot[bot] wants to merge 1 commit intodevelopfrom
Conversation
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 13.0.0 to 15.0.5. - [Release notes](https://github.com/testing-library/react-testing-library/releases) - [Changelog](https://github.com/testing-library/react-testing-library/blob/main/CHANGELOG.md) - [Commits](testing-library/react-testing-library@v13.0.0...v15.0.5) --- updated-dependencies: - dependency-name: "@testing-library/react" dependency-version: 15.0.5 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
48
to
+49
| "devDependencies": { | ||
| "@testing-library/react": "^13.0.0", | ||
| "@testing-library/react": "^15.0.5", |
There was a problem hiding this comment.
Bug: The renderHook import in profiler.test.tsx uses the deprecated @testing-library/react-hooks package, which is incompatible with React 18 and will cause test failures.
Severity: CRITICAL
Suggested Fix
In packages/react/test/profiler.test.tsx, change the import from @testing-library/react-hooks to @testing-library/react. Then, remove the @testing-library/react-hooks dependency from package.json.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/react/package.json#L48-L49
Potential issue: The PR upgrades `@testing-library/react`, which now includes the
`renderHook` function. However, the test file `packages/react/test/profiler.test.tsx`
continues to import `renderHook` from the old `@testing-library/react-hooks` package.
This package is still listed as a dev dependency but is incompatible with the project's
React 18 version. This mismatch will cause tests to fail at runtime, blocking the CI
pipeline and preventing the deployment of this change.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @testing-library/react from 13.0.0 to 15.0.5.
Release notes
Sourced from
@testing-library/react's releases.... (truncated)
Commits
f6a1677chore: Adjust tests to workaround 18.3.0 bug (#1315)d143f46fix: Stop restrictingcontaineroption based onhydrate(#1313)48282c2fix: EnsurerenderHookoptions extend options forrender(#1308)067d0c6fix: Don't raise TypeScript errors when hydatingdocument(#1304)c63b873fix: ImprovelegacyRooterror message (#1301)1645d21fix: Stop using nullish coalescing (#1299)787cb85Release: 15.0.0 (#1295)9c4a46dfeat: Add support for React 19 Canary (#1294)4e10ba3chore: change canary version to specific prefix (#1290)cf045b4chore: Update Codecov configuration to latest (#1289)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)