Skip to content

Conversation

@logaretm
Copy link
Collaborator

@logaretm logaretm commented Dec 3, 2025

This PR removes tracing logic from Pages Router API routes template (non-edge), completely switching our reliance to the spans created and emitted by Next.js.

@linear
Copy link

linear bot commented Dec 3, 2025

@logaretm logaretm force-pushed the awad/js-1209-remove-tracing-from-pages-router-api-2 branch from ebb5e84 to c59e752 Compare December 3, 2025 10:17
@logaretm logaretm force-pushed the awad/js-1209-remove-tracing-from-pages-router-api-2 branch from 2af20e5 to 2516846 Compare December 3, 2025 10:49
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,406 - 9,185 +2%
GET With Sentry 1,794 19% 1,801 -0%
GET With Sentry (error only) 6,293 67% 6,271 +0%
POST Baseline 1,200 - 1,203 -0%
POST With Sentry 604 50% 604 -
POST With Sentry (error only) 1,075 90% 1,074 +0%
MYSQL Baseline 3,427 - 3,372 +2%
MYSQL With Sentry 509 15% 465 +9%
MYSQL With Sentry (error only) 2,771 81% 2,751 +1%

View base workflow run

@logaretm logaretm force-pushed the awad/js-1209-remove-tracing-from-pages-router-api-2 branch from af76ad5 to fccd385 Compare December 3, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants