Skip to content

ref(core): Avoid boxing in DateUtils.nanosToDate #5523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
runningcode wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

ref(core): Avoid boxing in DateUtils.nanosToDate #5523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c33e743
ref(core): Avoid boxing in DateUtils.nanosToDate
runningcode Jun 10, 2026
39f8930
changelog
runningcode Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Improve SDK init performance by replacing `java.net.URI` with custom string parsing for DSN ([#5448](https://github.com/getsentry/sentry-java/pull/5448))
- Remove unnecessary boxing to improve performance ([#5520](https://github.com/getsentry/sentry-java/pull/5520))
- Reduce unboxing in `DateUtils.nanosToDate` ([#5523](https://github.com/getsentry/sentry-java/pull/5523))

@0xadam-brown 0xadam-brown Jun 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: Could just add the PR reference here to the line above, as this is a quick fix. Up to you of course.

@runningcode runningcode Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think we just made a release so I'll need to rebase this PR.


### Fixes

Expand Down
4 changes: 2 additions & 2 deletions sentry/src/main/java/io/sentry/DateUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ public static double nanosToMillis(final double nanos) {
* @return date rounded down to milliseconds
*/
public static Date nanosToDate(final long nanos) {
final Double millis = nanosToMillis((double) nanos);
return getDateTime(millis.longValue());
final double millis = nanosToMillis((double) nanos);
return getDateTime((long) millis);
}

public static @Nullable Date toUtilDate(final @Nullable SentryDate sentryDate) {
Expand Down
Loading